From: Andi Kleen <ak@suse.de>
To: Martin Diehl <lists@mdiehl.de>
Cc: Andi Kleen <ak@muc.de>, Jeff Garzik <jgarzik@pobox.com>,
netdev@oss.sgi.com, irda-users@lists.sourceforge.net,
Jean Tourrilhes <jt@hpl.hp.com>,
the_nihilant@autistici.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Drop ISA dependencies from IRDA drivers
Date: Fri, 16 Jul 2004 08:19:13 +0200 [thread overview]
Message-ID: <20040716061913.GB662@wotan.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0407160801190.14037-100000@notebook.home.mdiehl.de>
On Fri, Jul 16, 2004 at 08:19:04AM +0200, Martin Diehl wrote:
> On 16 Jul 2004, Andi Kleen wrote:
>
> > > Admittedly I haven't tried either, but I'm pretty sure this patch will
> > > break building those drivers because they are calling irda_setup_dma -
> > > which is CONFIG_ISA. Maybe this can be dropped but I don't see what's
> > > wrong with !64BIT instead.
> >
> > Hmm, good point.
> >
> > !64BIT is not needed - apparently they are 64bit clean.
>
> I think you are right - however, AFAICS this is not the point in this
> case. These drivers do DMA to legacy devices (call it ISA, LPC, whatever).
> The documented way for those devices without struct pci_dev is to call the
> dma api functions with dev=NULL. For i386 the generic dma functions are
> overwritten so they use GFP_DMA f.e. in this case.
There was at least one user report that at least one driver worked
with CONFIG_ISA force defined.
>
> According to include/asm-x86_64/dma-mapping.h there is no such override
> for x86-64. Hence the generic implementation is used which Oopses when
> called with dev=NULL in dma_alloc_coherent because it dereferences dev
> unconditionally.
The old pci_alloc_coherent supported hwdev == NULL under x86-64.
dma_alloc_consistent() should too. I will fix that.
-Andi
next prev parent reply other threads:[~2004-07-16 6:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m34qo96x8m.fsf@averell.firstfloor.org>
2004-07-15 16:48 ` Jeff Garzik
2004-07-15 20:50 ` Andi Kleen
2004-07-15 21:00 ` Jeff Garzik
2004-07-15 21:55 ` Andi Kleen
2004-07-15 22:32 ` Martin Diehl
2004-07-15 22:42 ` Jean Tourrilhes
2004-07-15 22:57 ` Martin Diehl
2004-07-16 5:45 ` Andi Kleen
2004-07-16 6:19 ` Martin Diehl
2004-07-16 6:19 ` Andi Kleen [this message]
2004-07-16 6:33 ` Martin Diehl
2004-07-15 22:35 ` Jean Tourrilhes
2004-07-16 5:36 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040716061913.GB662@wotan.suse.de \
--to=ak@suse.de \
--cc=ak@muc.de \
--cc=irda-users@lists.sourceforge.net \
--cc=jgarzik@pobox.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@mdiehl.de \
--cc=netdev@oss.sgi.com \
--cc=the_nihilant@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®