mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Eger <eger@havoc.gtf.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: [PATCH] pmac_zilog: fix patch drain bramage
Date: Sat, 17 Jul 2004 09:07:14 -0400	[thread overview]
Message-ID: <20040717130714.GA27891@havoc.gtf.org> (raw)
In-Reply-To: <20040716185832.GA8750@havoc.gtf.org>

How embarrassing.
One of the "if (!rc)"'s in that patch should be an "if (rc)".

-dte

Signed-off-by: David Eger <eger@havoc.gtf.org>

diff -Nru a/drivers/serial/pmac_zilog.c b/drivers/serial/pmac_zilog.c
--- a/drivers/serial/pmac_zilog.c	2004-07-17 09:04:47 -04:00
+++ b/drivers/serial/pmac_zilog.c	2004-07-17 09:04:47 -04:00
@@ -1801,7 +1801,7 @@
 	 * Register this driver with the serial core
 	 */
 	rc = uart_register_driver(&pmz_uart_reg);
-	if (rc != 0) 
+	if (rc)
 		return rc;
 
 	/*
@@ -1812,7 +1812,7 @@
 		/* NULL node may happen on wallstreet */
 		if (uport->node != NULL)
 			rc = uart_add_one_port(&pmz_uart_reg, &uport->port);
-		if (!rc)
+		if (rc)
 			goto err_out;
 	}
 

      parent reply	other threads:[~2004-07-17 13:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-12  7:51 pmac oops: devfs versus power management - fight! David Eger
2004-07-12  8:21 ` oops: pmac power management David Eger
2004-07-12 22:09   ` pmac_zilog: driver loads (and crashes) without hardware David Eger
2004-07-13  0:39     ` [PATCH] pmac_zilog: initialize port spinlock on all init paths David Eger
2004-07-13  4:16       ` Benjamin Herrenschmidt
2004-07-14  4:04         ` David Eger
2004-07-14 23:39           ` Tom Rini
2004-07-16 20:15             ` David Eger
2004-07-16 20:50               ` Tom Rini
2004-07-19 15:51               ` Anton Blanchard
2004-07-16 18:58         ` [PATCH] pmac_zilog: insert correct failure path for device numbers being taken David Eger
2004-07-16 19:01           ` Benjamin Herrenschmidt
2004-07-17 13:07           ` David Eger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040717130714.GA27891@havoc.gtf.org \
    --to=eger@havoc.gtf.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®