Re: [PATCH][2.4 Backport] x445 usb legacy fix

[Pete Zaitcev <zaitcev@redhat.com>]

On Mon, 19 Jul 2004 19:07:03 -0700
john stultz <johnstul@us.ibm.com> wrote:

The patch looks a little dirty in small places, e.g. the double
semicolon, the HZ/100 instead of HZ/10, space, two variables
named "base" in two blocks. I do not believe Vojtech wrote it.
He must have gotten it from someone else.

> While Greg was cautious that this method couldn't always be used, I've
> added to Vojtech's patch a boot option which allows you to specify
> "no-usb-legacy". Additionally this patch enables the "no-usb-legacy"
> option by default for x440/x445 systems.

The boot option may be useful, but in the core of the patch looks
like like a roundabout way to do things. Why don't you trigger
the meat of the quirk from, say, a DMI scan?

> +	{ PCI_FIXUP_FINAL,	PCI_ANY_ID,		PCI_ANY_ID,		quirk_usb_disable_smm_bios },

This looks like a bizzare place to use as a hook. The x400 and x445
obviously have their own bridges with own IDs (their NUMA cannot
be using Intel parts, right?). So why don't hook off that?

IIRC, we don't have 7 level of initcalls in 2.4, so perhaps you
need that particular hook location. But it just looks wrong.

The routines to take ownership look sane from USB HC access
(not sane from C programming standpoint, as I mentioned above).

But in any case, it's not something I can decide. Marcelo has that
power for stock kernels, and for Red Hat kernels there's a process
which starts with Bugzilla.

-- Pete