From: "bradgoodman.com" <bkgoodman@bradgoodman.com>
To: alan@redhat.com, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: [PATCH] 2.4.27 - MTD cfi_cmdset_0002.c - Duplicate cleanup in error path
Date: Fri, 23 Jul 2004 15:47:58 -0400 [thread overview]
Message-ID: <200407231947.i6NJlwo32224@bradgoodman.com> (raw)
Patch to 2.4.x: Corrects an obvious error where all of the cleanups are done
twice in the event of a chip programming error. This can result in
kernel BUG() getting called on subsequent programming attempts.
--- linux-2.4.22.prepatch/drivers/mtd/chips/cfi_cmdset_0002.c Fri Jun 13 10:51:34 2003
+++ linux-2.4.22/drivers/mtd/chips/cfi_cmdset_0002.new Thu Jul 15 14:44:30 2004
@@ -549,11 +549,6 @@
}
} else {
printk(KERN_WARNING "Waiting for write to complete timed out in do_write_oneword.");
-
- chip->state = FL_READY;
- wake_up(&chip->wq);
- cfi_spin_unlock(chip->mutex);
- DISABLE_VPP(map);
ret = -EIO;
}
}
next reply other threads:[~2004-07-23 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-23 19:47 bradgoodman.com [this message]
2004-07-24 7:14 ` Rainer Weikusat
2004-08-19 15:54 ` Marcelo Tosatti
2004-08-19 20:18 ` bkgoodman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200407231947.i6NJlwo32224@bradgoodman.com \
--to=bkgoodman@bradgoodman.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®