mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Rajesh Venkatasubramanian <vrajesh@umich.edu>
Cc: oleg@tv-sign.ru, linux-kernel@vger.kernel.org, hugh@veritas.com,
	torvalds@osdl.org
Subject: Re: [PATCH] prio_tree iterator cleanup.
Date: Mon, 26 Jul 2004 16:35:33 -0700	[thread overview]
Message-ID: <20040726163533.6f2fe0fa.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0407261626080.17181@red.engin.umich.edu>

Rajesh Venkatasubramanian <vrajesh@umich.edu> wrote:
>
> I have gone through all the 3 prio_tree patches you have sent
>  over the last few weeks. Your 2nd (kill vma_prio_tree_init) and
>  3rd (iterator cleanup) patches look straight-forward.
> 
>  I agree that vm_set.head linking is ugly. Your 1st patch
>  attempts to simplify it and removes few lines of code. However,
>  your 1st patch is intrusive and I am not convinced that it
>  improves the code very much.
> 
>  If you can post your 2nd and 3rd patches independent of your
>  first patch, that will be great. Please covert vma_prio_tree_next
>  in arch/* directories if you plan to post a new version of your
>  3rd patch.
> 
>  Overall I am inclined to leave the prio_tree code as it is.
>  However, your 2nd and 3rd patches are quiet straight-forward
>  and I am okay with them.

Thanks, Rajesh.

Oleg, I didn't apply any patches in this area.  Please reissue any
prio-tree patches from scratch.  Thanks.


  reply	other threads:[~2004-07-26 23:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-24 14:54 Oleg Nesterov
2004-07-26 20:47 ` Rajesh Venkatasubramanian
2004-07-26 23:35   ` Andrew Morton [this message]
2004-07-27 12:34 Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040726163533.6f2fe0fa.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=torvalds@osdl.org \
    --cc=vrajesh@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®