mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Janice M Girouard <janiceg@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, wenxiong@us.ibm.com,
	linux-serial@vger.kernel.org
Subject: Re: new device driver to enable the IBM Multiport Serial Adapter in Linux
Date: Tue, 27 Jul 2004 00:03:59 -0700	[thread overview]
Message-ID: <20040727000359.6e0af2e0.akpm@osdl.org> (raw)
In-Reply-To: <41055722.2070104@us.ibm.com>

Janice M Girouard <janiceg@us.ibm.com> wrote:
>
> The patch below enables the IBM Multiport Serial Adapter for the Linux 
>  OS.

Looks sane.  Did you really intend that it be buildable for all
architectures?  (There's nothing wrong with this - it's good.  But it's a
bit unusual for this sort of driver).

"IBM multiport serial adapter" seems to be a rather generic description of
this device.  Is this the only multiport serial adapter which IBM has ever,
or will ever make?  If not, then perhaps we could make the description a
little more specific?


  reply	other threads:[~2004-07-27  7:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-26 19:10 Janice M Girouard
2004-07-27  7:03 ` Andrew Morton [this message]
2004-07-27 15:22 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040727000359.6e0af2e0.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=janiceg@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=wenxiong@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®