Re: PATCH: Add support for Innovision DM-8401H

[Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>]

[ cc: linux-ide, please! ]

On Wednesday 28 of July 2004 15:49, Alan Cox wrote:
> This is an SII 680 with strange PCI identifiers it appears

No, this is a different chipset (produced by ITE).

> Original patch: Alex Hewson
> Verified by: Alan Cox <alan@redhat.com>

I asked you to compare Sil and ITE datasheets
(as I don't have one for Sil0680).

Have you done this?

> @@ -1634,6 +1634,7 @@
>  #define PCI_VENDOR_ID_ITE		0x1283
>  #define PCI_DEVICE_ID_ITE_IT8172G	0x8172
>  #define PCI_DEVICE_ID_ITE_IT8172G_AUDIO 0x0801
> +#define PCI_DEVICE_ID_ITE_DM8401	0x8212

This chipset is used by other cards as well.
 
> @@ -1108,7 +1111,8 @@
>  static ide_pci_device_t siimage_chipsets[] __devinitdata = {
>  	/* 0 */ DECLARE_SII_DEV("SiI680"),
>  	/* 1 */ DECLARE_SII_DEV("SiI3112 Serial ATA"),
> -	/* 2 */ DECLARE_SII_DEV("Adaptec AAR-1210SA")
> +	/* 2 */ DECLARE_SII_DEV("Adaptec AAR-1210SA"),
> +	/* 3 */ DECLARE_SII_DEV("InnoVISION DM8401H")
>  };

ditto