From: Tom Rini <trini@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: olh@suse.de, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.linuxppc.org, Sylvain Munaut <tnt@246tNt.com>,
Kumar Gala <kumar.gala@freescale.com>
Subject: Re: [PATCH][PPC32] Makefile cleanups and gcc-3.4+binutils-2.14 check
Date: Wed, 28 Jul 2004 15:07:33 -0700 [thread overview]
Message-ID: <20040728220733.GA16468@smtp.west.cox.net> (raw)
In-Reply-To: <20040728150052.4effe78a.akpm@osdl.org>
On Wed, Jul 28, 2004 at 03:00:52PM -0700, Andrew Morton wrote:
> Tom Rini <trini@kernel.crashing.org> wrote:
> >
> > The following patch does three things. First, it removes all instances
> > of:
> > ifeq ($(CONFIG_FOO),y)
> > AFLAGS += -Wa,-mfoo
> > endif
> >
> > and makes us set them once in arch/ppc/Makefile, via
> > aflags-$(CONFIG_FOO), just like we do for CFLAGS. Next it adds a test
> > for gcc-3.4 and binutils-2.14. The problem with this combination is
> > that the -many flag is broken in binutils-2.14 and gcc-3.4 will pass it
> > down, causing other flags to be overridden and the compile to fail.
> > Changing gcc or binutils versions fixes this. Finally, it changes
> > places in the Makefiles where we did:
> > ifeq ($(CONFIG_FOO),y)
> > obj-$(CONFIG_BAR) += foo_bar.o
> > endif
> > into
> > obj-$(CONFIG_FOO) += $(bar-y)
> > bar-$(CONFIG_BAR) += foo_bar.o
>
> Unfortunately this has significant clashes with the mpc52xx bk tree
> which I'm carrying.
>
> That patch has been sitting around for several weeks now - can we get it
> merged up first?
I talked with Kumar Gala at OLS, and I believe everyone (ppc) is happy
with mpc52xx stuff. So yes, that can go out.
I've taken the binutils-2.14+gcc-3.4 bit out (and none of the other
cleanups) as it seems like we get 1-2 reports a week from this bad tools
combination:
Signed-off-by: Tom Rini <trini@kernel.crashing.org>
===== arch/ppc/Makefile 1.55 vs edited =====
--- 1.55/arch/ppc/Makefile 2004-07-05 03:27:10 -07:00
+++ edited/arch/ppc/Makefile 2004-07-15 07:20:40 -07:00
@@ -106,17 +106,24 @@
else
NEW_AS := 0
endif
+# gcc-3.4 and binutils-2.14 are a fatal combination.
+GCC_VERSION := $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC))
+BAD_GCC_AS := $(shell echo mftb 5 | $(AS) -mppc -many -o /dev/null >/dev/null 2>&1 && echo 0 || echo 1)
-ifneq ($(NEW_AS),0)
checkbin:
+ifeq ($(GCC_VERSION)$(BAD_GCC_AS),03041)
+ @echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no longer build '
+ @echo 'correctly with gcc-3.4 and your version of binutils.'
+ @echo '*** Please upgrade your binutils or downgrade your gcc'
+ @false
+endif
+ifneq ($(NEW_AS),0)
@echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no longer build '
@echo 'correctly with old versions of binutils.'
@echo '*** Please upgrade your binutils to ${GOODVER} or newer'
@false
-else
-checkbin:
- @true
endif
+ @true
CLEAN_FILES += include/asm-$(ARCH)/offsets.h \
arch/$(ARCH)/kernel/asm-offsets.s
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2004-07-28 22:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 15:46 Tom Rini
2004-07-28 22:00 ` Andrew Morton
2004-07-28 22:07 ` Tom Rini [this message]
2004-07-28 22:51 ` Andrew Morton
2004-07-29 15:04 ` Sylvain Munaut
2004-07-29 8:05 ` [PATCH][PPC32] Makefile cleanups and gcc-3.4+binutils-2.14 c Giuliano Pochini
2004-07-29 14:43 ` Tom Rini
2004-07-30 18:59 ` Giuliano Pochini
2004-07-30 19:07 ` Tom Rini
2004-07-30 20:48 ` Giuliano Pochini
2004-07-30 21:03 ` Tom Rini
2004-08-04 10:22 ` Wolfram Quester
2004-08-04 10:41 ` Guido Guenther
2004-08-04 12:37 ` Guido Guenther
2004-08-05 14:12 ` Olaf Hering
2004-08-05 16:54 ` Tom Rini
2004-08-05 17:00 ` Olaf Hering
2004-08-05 17:20 ` Tom Rini
2004-08-05 17:39 ` Olaf Hering
2004-08-05 18:03 ` Tom Rini
2004-08-05 18:00 ` Olaf Hering
2004-08-05 18:14 ` Tom Rini
2004-08-05 19:04 ` Sam Ravnborg
2004-08-05 21:03 ` Matt Porter
2004-08-06 15:32 ` Olaf Hering
[not found] ` <hhacx8hirb.fsf@alsvidh.mathematik.uni-muenchen.de>
2004-08-06 15:38 ` [PATCH] ppc32: Fix building of certain CPU types (Was: Re: [PATCH][PPC32] Makefile cleanups and gcc-3.4+binutils-2.14) Tom Rini
2004-08-02 7:45 ` [PATCH][PPC32] Makefile cleanups and gcc-3.4+binutils-2.14 c Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040728220733.GA16468@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=kumar.gala@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=olh@suse.de \
--cc=tnt@246tNt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®