From: Adrian Bunk <bunk@fs.tum.de>
To: Andrew Morton <akpm@osdl.org>
Cc: chas@cmf.nrl.navy.mil, linux-atm-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [2.6 patch] net/atm/lec.c: remove inlines (fwd)
Date: Thu, 29 Jul 2004 23:22:00 +0200 [thread overview]
Message-ID: <20040729212159.GE23589@fs.tum.de> (raw)
FYI:
The patch forwarded below is still required in 2.6.8-rc2-mm1.
----- Forwarded message from Adrian Bunk <bunk@fs.tum.de> -----
Date: Thu, 15 Jul 2004 21:17:10 +0200
From: Adrian Bunk <bunk@fs.tum.de>
To: carnil@cs.tut.fi
Cc: chas@cmf.nrl.navy.mil, linux-atm-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [2.6 patch] net/atm/lec.c: remove inlines
Trying to compile net/atm/lec.c in 2.6.8-rc1-mm1 using gcc 3.4 results
in the following compile error:
<-- snip -->
...
CC net/atm/lec.o
net/atm/lec.c: In function `lec_atm_send':
net/atm/lec.c:75: sorry, unimplemented: inlining failed in call to
'lec_arp_find': function body not available
net/atm/lec.c:459: sorry, unimplemented: called from here
net/atm/lec.c:77: sorry, unimplemented: inlining failed in call to
'lec_arp_remove': function body not available
net/atm/lec.c:460: sorry, unimplemented: called from here
make[2]: *** [net/atm/lec.o] Error 1
<-- snip -->
The patch below removes the inlines from the functions in question.
An alternative approach would be to move the inline functions above the
first place where they are used.
diffstat output:
net/atm/lec.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
--- linux-2.6.7-mm6-full-gcc3.4/net/atm/lec.c.old 2004-07-09 02:12:36.000000000 +0200
+++ linux-2.6.7-mm6-full-gcc3.4/net/atm/lec.c 2004-07-09 02:15:16.000000000 +0200
@@ -71,9 +71,9 @@
static int lec_close(struct net_device *dev);
static struct net_device_stats *lec_get_stats(struct net_device *dev);
static void lec_init(struct net_device *dev);
-static inline struct lec_arp_table* lec_arp_find(struct lec_priv *priv,
+static struct lec_arp_table* lec_arp_find(struct lec_priv *priv,
unsigned char *mac_addr);
-static inline int lec_arp_remove(struct lec_priv *priv,
+static int lec_arp_remove(struct lec_priv *priv,
struct lec_arp_table *to_remove);
/* LANE2 functions */
static void lane2_associate_ind (struct net_device *dev, u8 *mac_address,
@@ -1468,7 +1468,7 @@
/*
* Remove entry from lec_arp_table
*/
-static inline int
+static int
lec_arp_remove(struct lec_priv *priv,
struct lec_arp_table *to_remove)
{
@@ -1755,7 +1755,7 @@
/*
* Find entry by mac_address
*/
-static inline struct lec_arp_table*
+static struct lec_arp_table*
lec_arp_find(struct lec_priv *priv,
unsigned char *mac_addr)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
----- End forwarded message -----
reply other threads:[~2004-07-29 21:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040729212159.GE23589@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=akpm@osdl.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®