mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH] Improve pci_alloc_consistent wrapper on preemptive kernels
Date: Fri, 30 Jul 2004 13:02:38 -0700	[thread overview]
Message-ID: <20040730130238.0f68f5e7.akpm@osdl.org> (raw)
In-Reply-To: <20040730190227.29913e23.ak@suse.de>

Andi Kleen <ak@suse.de> wrote:
>
> This is a minor optimization for the pci_alloc_consistent wrapper for
>  the generic dma API. When the kernel is compiled preemptive the caller
>  can decide if the allocation needs to be GFP_KERNEL or GFP_ATOMIC.

We're paying for past sins here.  I think it would be better to create a
new version of pci_alloc_consistent() which takes gfp_flags, then migrate
the drivers you care about to use it.  That way the benefit is available on
non-preempt kernels too.

The ultimate aim of course would be to deprecate then remove the old
function.


  parent reply	other threads:[~2004-07-30 20:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-30 17:02 Andi Kleen
2004-07-30 17:16 ` Jeff Garzik
2004-07-30 17:43   ` Andi Kleen
2004-07-30 18:07     ` Jeff Garzik
2004-07-30 18:47       ` Takashi Iwai
2004-07-30 19:28         ` Takashi Iwai
2004-07-30 21:42       ` Andi Kleen
2004-07-30 20:02 ` Andrew Morton [this message]
2004-07-30 20:13   ` James Bottomley
2004-07-30 20:20     ` Andrew Morton
2004-07-30 20:28       ` James Bottomley
     [not found] <2nJ3t-34a-39@gated-at.bofh.it>
     [not found] ` <2nJmP-3eq-9@gated-at.bofh.it>
     [not found]   ` <2nJG8-3p6-21@gated-at.bofh.it>
     [not found]     ` <2nK9b-3PM-17@gated-at.bofh.it>
2004-07-30 18:34       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040730130238.0f68f5e7.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®