mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: adaplas@pol.net
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Fbdev development list 
	<linux-fbdev-devel@lists.sourceforge.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] [I810FB]: i810fb fixes
Date: Sat, 31 Jul 2004 02:07:54 +0200	[thread overview]
Message-ID: <20040731000754.GF2746@fs.tum.de> (raw)
In-Reply-To: <200407290955.29735.adaplas@hotpop.com>

On Thu, Jul 29, 2004 at 10:04:32AM +0800, Antonino A. Daplas wrote:

>...
> --- linux-2.6.8-rc2-mm1-orig/drivers/video/Kconfig	2004-07-28 19:51:13.000000000 +0000
> +++ linux-2.6.8-rc2-mm1/drivers/video/Kconfig	2004-07-29 00:35:04.115437224 +0000
> @@ -457,7 +457,9 @@ config FB_RIVA_DEBUG
>  
>  config FB_I810
>  	tristate "Intel 810/815 support (EXPERIMENTAL)"
> -	depends on FB && AGP && AGP_INTEL && EXPERIMENTAL && PCI	
> +	depends on FB && EXPERIMENTAL && PCI	
> +	select AGP
> +	select AGP_INTEL
>  	help
>  	  This driver supports the on-board graphics built in to the Intel 810 
>            and 815 chipsets.  Say Y if you have and plan to use such a board.
>...

This is wrong.

If you select something, you have to ensure that the dependencies of 
what you select are fulfilled.

Since AGP_INTEL depends on X86 && !X86_64 , you must add this to the 
dependencies of FB_I810 if it selects AGP_INTEL.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2004-07-31  0:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-29  2:04 Antonino A. Daplas
2004-07-31  0:07 ` Adrian Bunk [this message]
2004-07-31 10:26   ` [Linux-fbdev-devel] " Antonino A. Daplas
2004-07-31 10:32   ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040731000754.GF2746@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=adaplas@pol.net \
    --cc=akpm@osdl.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®