From: Willy Tarreau <willy@w.ods.org>
To: Ben Greear <greearb@candelatech.com>
Cc: Matti Aarnio <matti.aarnio@zmailer.org>,
Jeff Garzik <jgarzik@pobox.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
akpm@osdl.org, alan@redhat.com, jgarzik@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: PATCH: VLAN support for 3c59x/3c90x
Date: Sat, 31 Jul 2004 19:05:51 +0200 [thread overview]
Message-ID: <20040731170551.GA27559@alpha.home.local> (raw)
In-Reply-To: <410BD0E3.2090302@candelatech.com>
Hi Ben,
On Sat, Jul 31, 2004 at 10:03:31AM -0700, Ben Greear wrote:
> VLAN allows you to continue using the ethX interface as a regular
> ethernet interface, so you do not generally want it's MTU to be set
> to 1504 because then the other peer ethernet interfaces would also
> have to be set to 1504. I believe it is much better to silently let
> the extra 4 bytes pass but NOT advertise this extra 4 bytes to
> anything that actually cares about MTU.
I 100% agree with you on this one, but I don't see how playing with
change_mtu() would change anything. Ideally, we would need to export
the level 2 limit (imposed by hardware and intermediate switches) to
other drivers such as 802_1q, and let only the IP stack rely on dev->mtu.
I've seen several drivers which silently add 4 bytes to the hardware
config when CONFIG_VLAN is set. I find it better than fooling the IP
stack into using 1504 bytes, which is a disaster on UDP !
Cheers,
Willy
next prev parent reply other threads:[~2004-07-31 17:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 12:42 Alan Cox
2004-07-28 21:33 ` Ben Greear
2004-07-28 22:15 ` Alan Cox
2004-07-28 22:30 ` Ben Greear
2004-07-29 17:19 ` Alan Cox
2004-07-28 21:36 ` Andrew Morton
2004-07-28 21:45 ` Ben Greear
2004-07-29 4:18 ` Willy Tarreau
2004-07-30 2:20 ` Herbert Xu
2004-07-30 12:10 ` Willy Tarreau
2004-07-31 3:57 ` Herbert Xu
2004-07-31 8:33 ` Willy Tarreau
[not found] ` <200407310846.i6V8k3qq006659@uai.com.br>
2004-07-31 8:57 ` Willy Tarreau
2004-07-31 9:34 ` Jeff Garzik
2004-07-31 10:11 ` Willy Tarreau
2004-07-31 14:12 ` Matti Aarnio
2004-07-31 16:18 ` Jeff Garzik
2004-07-31 17:13 ` Ben Greear
2004-07-31 17:03 ` Ben Greear
2004-07-31 17:05 ` Willy Tarreau [this message]
2004-07-31 17:21 ` Ben Greear
2004-07-31 20:16 ` Lee Revell
2004-07-31 20:23 ` Willy Tarreau
2004-07-31 20:25 ` Alan Cox
2004-07-31 20:40 ` Lee Revell
2004-08-06 12:30 ` Willy Tarreau
2004-07-31 16:05 ` Jeff Garzik
2004-07-31 16:12 ` Willy Tarreau
2004-07-31 16:26 ` Jeff Garzik
2004-07-31 21:06 ` PATCH-2.4: MTU fix for tulip driver Willy Tarreau
2004-07-31 9:35 ` PATCH: VLAN support for 3c59x/3c90x Herbert Xu
2004-07-31 10:01 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040731170551.GA27559@alpha.home.local \
--to=willy@w.ods.org \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=greearb@candelatech.com \
--cc=herbert@gondor.apana.org.au \
--cc=jgarzik@pobox.com \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.aarnio@zmailer.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®