From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267936AbUGaKcr (ORCPT ); Sat, 31 Jul 2004 06:32:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267938AbUGaKcr (ORCPT ); Sat, 31 Jul 2004 06:32:47 -0400 Received: from [38.113.3.51] ([38.113.3.51]:40891 "EHLO snickers.hotpop.com") by vger.kernel.org with ESMTP id S267936AbUGaKcp (ORCPT ); Sat, 31 Jul 2004 06:32:45 -0400 From: "Antonino A. Daplas" Reply-To: adaplas@pol.net To: Adrian Bunk Subject: Re: [Linux-fbdev-devel] Re: [PATCH 5/5] [I810FB]: i810fb fixes Date: Sat, 31 Jul 2004 18:32:29 +0800 User-Agent: KMail/1.5.4 Cc: Andrew Morton , Linux Fbdev development list , linux-kernel@vger.kernel.org References: <200407290955.29735.adaplas@hotpop.com> <20040731000754.GF2746@fs.tum.de> In-Reply-To: <20040731000754.GF2746@fs.tum.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200407311832.29250.adaplas@hotpop.com> X-HotPOP: ----------------------------------------------- Sent By HotPOP.com FREE Email Get your FREE POP email at www.HotPOP.com ----------------------------------------------- Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Oops, forgot the X86_64 dependency. Tony 1. Make i810fb depend on X86 but not X86_64 2. Fixed typo in i810_init_monspecs(). Reported by Manuel Lauss . Signed-off-by: Antonino Daplas --- diff -uprN linux-2.6.8-rc2-mm1-orig/drivers/video/i810/i810_main.c linux-2.6.8-rc2-mm1/drivers/video/i810/i810_main.c --- linux-2.6.8-rc2-mm1-orig/drivers/video/i810/i810_main.c 2004-07-31 16:52:12.341681400 +0800 +++ linux-2.6.8-rc2-mm1/drivers/video/i810/i810_main.c 2004-07-31 16:53:18.937557288 +0800 @@ -1656,7 +1656,7 @@ static void __devinit i810_init_monspecs info->monspecs.hfmax = hsync2; if (!info->monspecs.hfmin) info->monspecs.hfmin = hsync1; - if (hsync1 < hsync2) + if (hsync2 < hsync1) info->monspecs.hfmin = hsync2; if (!vsync1) diff -uprN linux-2.6.8-rc2-mm1-orig/drivers/video/Kconfig linux-2.6.8-rc2-mm1/drivers/video/Kconfig --- linux-2.6.8-rc2-mm1-orig/drivers/video/Kconfig 2004-07-31 16:52:12.337682008 +0800 +++ linux-2.6.8-rc2-mm1/drivers/video/Kconfig 2004-07-31 18:29:37.812034832 +0800 @@ -457,7 +457,7 @@ config FB_RIVA_DEBUG config FB_I810 tristate "Intel 810/815 support (EXPERIMENTAL)" - depends on FB && EXPERIMENTAL && PCI + depends on FB && EXPERIMENTAL && PCI && X86 && !X86_64 select AGP select AGP_INTEL help