From: Andrew Morton <akpm@osdl.org>
To: Anton Blanchard <anton@samba.org>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use for_each_cpu
Date: Sun, 1 Aug 2004 00:47:08 -0700 [thread overview]
Message-ID: <20040801004708.6fa9f6f8.akpm@osdl.org> (raw)
In-Reply-To: <20040801072711.GJ30253@krispykreme>
Anton Blanchard <anton@samba.org> wrote:
>
>
> > > The per cpu schedule counters need to be summed up over all possible cpus.
> > > When testing hotplug cpu remove I saw the sum of the online cpu count
> > > for nr_uninterruptible go negative which made the load average go nuts.
> >
> > I think the preferred approach here is to transfer the count over to the
> > current CPU in the CPU_DEAD handler.
>
> They only look to be called out of proc, and once every 5 seconds for
> loadaverage calculations.
OK.
> Is it worth adding complexity to the cpu
> notifiers vs just using for_each_cpu?
yup ;) It's only six lines, and it follows the same pattern as is used in,
say, page_alloc_cpu_notify(). Doing the same thing the same way in
multiple places is to be preferred, yes?
next prev parent reply other threads:[~2004-08-01 7:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-01 6:01 Anton Blanchard
2004-08-01 6:08 ` Andrew Morton
2004-08-01 7:27 ` Anton Blanchard
2004-08-01 7:47 ` Andrew Morton [this message]
2004-08-01 21:00 ` Anton Blanchard
2004-08-02 5:59 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040801004708.6fa9f6f8.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome