From: Adrian Bunk <bunk@fs.tum.de>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: jgarzik@pobox.com, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: [2.6 patch] net/hamachi.c: remove bogus inline at function prototype (fwd)
Date: Sun, 1 Aug 2004 13:38:09 +0200 [thread overview]
Message-ID: <20040801113809.GM2746@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.60.0408011314480.2535@dragon.hygekrogen.localhost>
On Sun, Aug 01, 2004 at 01:21:22PM +0200, Jesper Juhl wrote:
>...
> Wouldn't it make sense to also un-inline hamachi_tx? both the _rx and _tx
My primary goal was to fix the compilation with gcc 3.4, not to evaluate
all inlines (which is also a good thing to do).
> functions are quite big - are they really suitable to be inlined?
Each of thamachi_{tx,rx} has exacly one caller, which might be a reason
in favor of inlining.
> Here's a proposed patch against 2.6.8-rc2-mm1
>...
Looks good.
> /Jesper Juhl
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2004-08-01 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-29 14:05 Adrian Bunk
2004-08-01 11:21 ` Jesper Juhl
2004-08-01 11:38 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040801113809.GM2746@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®