From: William Lee Irwin III <wli@holomorphy.com>
To: Zwane Mwaikambo <zwane@linuxpower.ca>
Cc: Paul Jackson <pj@sgi.com>, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH][2.6] first/next_cpu returns values > NR_CPUS
Date: Sun, 1 Aug 2004 05:40:53 -0700 [thread overview]
Message-ID: <20040801124053.GS2334@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0408010316590.4095@montezuma.fsmlabs.com>
On Sun, Aug 01, 2004 at 03:22:56AM -0400, Zwane Mwaikambo wrote:
> NR_CPUS was 3, the test case may as well be passing first_cpu or next_cpu
> a value of 0 for the map. The "bug" in the i386 find_next_bit really
> looks like a feature if you look at the code.
Hmm. I'm actually somewhat puzzled by this also. Shouldn't things only
check for inequalities between the results of these and NR_CPUS? i.e.
things like:
if (any_online_cpu(cpus) >= NR_CPUS)
and
for (cpu = first_cpu(cpus); cpu < NR_CPUS; cpu = next_cpu(cpus))
etc.?
Maybe the few callers that are sensitive to the precise return value
should use min_t(int, NR_CPUS, ...) instead of all callers taking the
branch on behalf of those few.
-- wli
next prev parent reply other threads:[~2004-08-01 12:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-31 20:52 Zwane Mwaikambo
2004-07-31 20:57 ` William Lee Irwin III
2004-07-31 23:02 ` Zwane Mwaikambo
2004-08-01 6:21 ` Paul Jackson
2004-08-01 7:22 ` Zwane Mwaikambo
2004-08-01 11:20 ` Paul Jackson
2004-08-01 14:51 ` Zwane Mwaikambo
2004-08-01 12:40 ` William Lee Irwin III [this message]
2004-08-01 13:05 ` Paul Jackson
2004-08-01 13:10 ` William Lee Irwin III
2004-08-01 13:36 ` Paul Jackson
2004-08-01 13:41 ` William Lee Irwin III
2004-08-01 13:47 ` Paul Jackson
2004-08-02 22:00 ` Matthew Dobson
2004-08-05 16:50 ` OGAWA Hirofumi
2004-08-05 17:01 ` William Lee Irwin III
2004-08-05 17:42 ` Andrew Morton
2004-08-05 18:13 ` Roman Zippel
2004-08-01 14:54 ` Zwane Mwaikambo
2004-08-01 15:05 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040801124053.GS2334@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome