mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: viro@parcelfarce.linux.theplanet.co.uk
To: Maneesh Soni <maneesh@in.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] Change sysfs_file_operations
Date: Tue, 3 Aug 2004 13:57:56 +0100	[thread overview]
Message-ID: <20040803125756.GV12308@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040729204359.GF4592@in.ibm.com>

On Thu, Jul 29, 2004 at 03:43:59PM -0500, Maneesh Soni wrote:
> 
> 
> 
> o This patch modifies the sysfs_file_operations methods so as to get the
>   kobject and attribute pointers via corresponding sysfs_dirent.

Hmm...  After looking at that, I'd probably add typed inlined helpers
(dentry to attr, dentry to kobject, dentry to bin_attr) and converted
to their use *before* everything else (patch #0).  And change their
definitions to use sysfs_dirent in patch #1.  That way we avoid breakage
on intermediate stages.

  parent reply	other threads:[~2004-08-03 13:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-29 20:37 [PATCH 0/5] sysfs backing store (Re-splitted) Maneesh Soni
2004-07-29 20:38 ` [PATCH 1/5] Add sysfs_dirent to sysfs dentry Maneesh Soni
2004-07-29 20:39   ` [PATCH 2/5] Use sysfs_dirent tree for ->readdir etc Maneesh Soni
2004-07-29 20:40     ` [PATCH 3/5] Free sysfs_dirent on file removal Maneesh Soni
2004-07-29 20:43       ` [PATCH 4/5] Change sysfs_file_operations Maneesh Soni
2004-07-29 20:44         ` [PATCH 5/5] Stop pinning dentries & inodes for leaves Maneesh Soni
2004-08-03 13:02           ` viro
2004-08-03 12:57         ` viro [this message]
2004-08-03 12:52       ` [PATCH 3/5] Free sysfs_dirent on file removal viro
2004-08-03 12:47     ` [PATCH 2/5] Use sysfs_dirent tree for ->readdir etc viro
2004-08-03 12:43   ` [PATCH 1/5] Add sysfs_dirent to sysfs dentry viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040803125756.GV12308@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maneesh@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®