mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@csd.uu.se>
To: linux-kernel@vger.kernel.org
Subject: updated gcc-3.4 patches for 2.4.27-rc4
Date: Tue, 3 Aug 2004 21:02:22 +0200 (MEST)	[thread overview]
Message-ID: <200408031902.i73J2MNx000087@harpo.it.uu.se> (raw)

[Resend. 1st post seems to have gone into a /dev/null somewhere.]

The gcc-3.4 patches for the 2.4.27-rc4 kernel have been updated:
http://www.csd.uu.se/~mikpe/linux/patches/2.4/patch-gcc34-fastcall-fixes-2.4.27-rc4
http://www.csd.uu.se/~mikpe/linux/patches/2.4/patch-gcc34-lvalue-fixes-2.4.27-rc4
http://www.csd.uu.se/~mikpe/linux/patches/2.4/patch-gcc34-misc-fixes-2.4.27-rc4
Download and apply all three of them.

After a careful review of all patches, the following changes were made:
- i386' smp_send_reschedule() now has proper fastcall declarations.
  The previous patches removed the FASTCALL from <linux/smp.h>,
  but the new patches instead preserve the behaviour from gcc < 3.4.
- Several functions had their fastcall annotations moved around a
  little to match exactly their 2.6.8-rc2 versions.
- A few void* casts used for cast-as-lvalue fixes were reformatted
  to match exactly their 2.6.8-rc2 versions.
- Cleaned up the cast-as-lvalue fix in
  arch/x86_64/ia32/ia32_ioctl.c:blkpg_ioctl_trans().

The cast-as-lvalue fixes for kernel/sysctl.c result in code doing
pointer arithmetic on void* values. There has been some discussion
about replacing those with char* values. I decided against that
because (1) the diff became larger, and (2) the functions in sysctl.c
already do void* pointer arithmetic, and there is no strong reason
for eliminating that (ab)use in the 2.4 kernel.

The cast-as-lvalue fixes are also needed to silence warnings from
gcc-3.3.4.

/Mikael

             reply	other threads:[~2004-08-03 19:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-03 19:02 Mikael Pettersson [this message]
2004-08-03 19:34 ` Adrian Bunk
2004-08-03 21:11 Mikael Pettersson
2004-08-03 22:25 O.Sezer
2004-08-04  9:19 Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200408031902.i73J2MNx000087@harpo.it.uu.se \
    --to=mikpe@csd.uu.se \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®