From: Francois Romieu <romieu@fr.zoreil.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Andrew Morton <akpm@osdl.org>,
ecd@atecom.com, chas@cmf.nrl.navy.mil,
linux-atm-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] idt77252.c: add missing pci_enable_device()
Date: Tue, 3 Aug 2004 21:57:44 +0200 [thread overview]
Message-ID: <20040803215744.A11997@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <200408031350.21349.bjorn.helgaas@hp.com>; from bjorn.helgaas@hp.com on Tue, Aug 03, 2004 at 01:50:21PM -0600
Bjorn Helgaas <bjorn.helgaas@hp.com> :
[...]
> ===== drivers/atm/idt77252.c 1.24 vs edited =====
> --- 1.24/drivers/atm/idt77252.c 2004-07-12 02:01:05 -06:00
> +++ edited/drivers/atm/idt77252.c 2004-07-30 13:45:42 -06:00
> @@ -3684,6 +3684,11 @@
> int i;
>
>
> + if (pci_enable_device(pcidev)) {
> + printk("idt77252: can't enable PCI device at %s\n", pci_name(pcidev));
> + return -ENODEV;
> + }
> +
> if (pci_read_config_word(pcidev, PCI_REVISION_ID, &revision)) {
> printk("idt77252-%d: can't read PCI_REVISION_ID\n", index);
> return -ENODEV;
It should be balanced by pci_disable_device() on close + error path.
--
Ueimor
next prev parent reply other threads:[~2004-08-03 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-03 19:50 Bjorn Helgaas
2004-08-03 19:57 ` Francois Romieu [this message]
2004-08-04 16:23 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040803215744.A11997@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=ecd@atecom.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®