From: Jesse Barnes <jbarnes@engr.sgi.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] don't pass mem_map into init functions
Date: Wed, 4 Aug 2004 11:48:03 -0700 [thread overview]
Message-ID: <200408041148.03729.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <1091581282.27397.6676.camel@nighthawk>
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On Tuesday, August 3, 2004 6:01 pm, Dave Hansen wrote:
> Jesse, could you follow up to this mail with a copy of your patch?
>
> Attached patch is against 2.6.8-rc2-mm2.
Fix up ia64 specific memory map init function in light of Dave's memmap_init
cleanups.
Signed-off-by: Jesse Barnes <jbarnes@sgi.com>
Jesse
[-- Attachment #2: memmap-cleanup-fix-2.patch --]
[-- Type: text/plain, Size: 1611 bytes --]
diff -Napur -X /home/jbarnes/dontdiff linux-2.6.8-rc2-mm2.orig/arch/ia64/mm/init.c linux-2.6.8-rc2-mm2/arch/ia64/mm/init.c
--- linux-2.6.8-rc2-mm2.orig/arch/ia64/mm/init.c 2004-08-04 11:45:06.000000000 -0700
+++ linux-2.6.8-rc2-mm2/arch/ia64/mm/init.c 2004-08-04 11:47:29.000000000 -0700
@@ -433,14 +433,16 @@ virtual_memmap_init (u64 start, u64 end,
}
void
-memmap_init (struct page *start, unsigned long size, int nid,
- unsigned long zone, unsigned long start_pfn)
+memmap_init (unsigned long size, int nid, unsigned long zone,
+ unsigned long start_pfn)
{
if (!vmem_map)
memmap_init_zone(start, size, nid, zone, start_pfn);
else {
+ struct page *start;
struct memmap_init_callback_data args;
+ start = pfn_to_page(start_pfn);
args.start = start;
args.end = start + size;
args.nid = nid;
diff -Napur -X /home/jbarnes/dontdiff linux-2.6.8-rc2-mm2.orig/include/asm-ia64/pgtable.h linux-2.6.8-rc2-mm2/include/asm-ia64/pgtable.h
--- linux-2.6.8-rc2-mm2.orig/include/asm-ia64/pgtable.h 2004-08-04 11:45:08.000000000 -0700
+++ linux-2.6.8-rc2-mm2/include/asm-ia64/pgtable.h 2004-08-04 11:45:40.000000000 -0700
@@ -520,7 +520,7 @@ do { \
# ifdef CONFIG_VIRTUAL_MEM_MAP
/* arch mem_map init routine is needed due to holes in a virtual mem_map */
# define __HAVE_ARCH_MEMMAP_INIT
- extern void memmap_init (struct page *start, unsigned long size, int nid, unsigned long zone,
+ extern void memmap_init (unsigned long size, int nid, unsigned long zone,
unsigned long start_pfn);
# endif /* CONFIG_VIRTUAL_MEM_MAP */
# endif /* !__ASSEMBLY__ */
next prev parent reply other threads:[~2004-08-04 18:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-04 1:01 Dave Hansen
2004-08-04 18:48 ` Jesse Barnes [this message]
2004-08-05 4:42 ` Andrew Morton
2004-08-05 18:55 ` Dave Hansen
2004-08-05 21:13 ` Andrew Morton
2004-08-05 23:58 ` Dave Hansen
-- strict thread matches above, loose matches on Subject: below --
2004-07-28 20:55 Dave Hansen
2004-07-28 21:58 ` Jesse Barnes
2004-07-28 22:01 ` Jesse Barnes
2004-07-28 22:19 ` Dave Hansen
2004-07-28 22:39 ` Jesse Barnes
2004-07-28 23:18 ` Dave Hansen
2004-07-29 1:33 ` Jesse Barnes
2004-07-29 23:10 ` Dave Hansen
2004-07-30 14:29 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408041148.03729.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome