From: Andrew Morton <akpm@osdl.org>
To: Josh Aas <josha@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: why hold bkl during do_coredump?
Date: Wed, 4 Aug 2004 21:18:27 -0700 [thread overview]
Message-ID: <20040804211827.7ace9325.akpm@osdl.org> (raw)
In-Reply-To: <410FDF04.9000609@sgi.com>
Josh Aas <josha@sgi.com> wrote:
>
> I'm looking at not holding the bkl during do_coredump, but I can't
> figure out why its being held in the first place. I can only think of
> the need to not mess with the current memory map, but mmap_sem is
> currently held as well. Anybody know what is going on here?
The only thing I can see in there which needs lock_kernel() is the access
to core_pattern - it's changed by sysctl, which also takes lock_kernel().
Probably, adding a lock_kernel() and a comment around the call to
format_corename() should suffice. Please make format_corename() static
while you're there.
prev parent reply other threads:[~2004-08-05 4:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-03 18:52 Josh Aas
2004-08-05 4:18 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040804211827.7ace9325.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=josha@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®