On Donnerstag, 5. August 2004 21:57, Alessandro Amici wrote: > I don't have enough knowledge to comment on the merit of the move to > architecture files, but the proliferation of #ifndef CONFIG_SMP looks really > ugly. Yes, it does. > Wouldn't it be possible to move the #ifndef into sched.h? You can't simply define it to a nop in case of SMP, because there it is called from a different place, but we could have a separate version for UP and SMP in sched.h: void update_process_times(int user_tick); static inline void update_process_times_nonsmp(int user_tick) { #ifndef CONFIG_SMP update_process_times(user_tick); #endif } Arnd <><