mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: qeth performance.
Date: Fri, 6 Aug 2004 15:09:42 +0200	[thread overview]
Message-ID: <20040806130942.GB2065@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <OFECABF5A6.F2037B97-ON42256EE8.00472EEA-42256EE8.0047790E@de.ibm.com>

On Fri, 6 August 2004 15:00:40 +0200, Martin Schwidefsky wrote:
> Jörn Engel <joern@wohnheim.fh-wedel.de> wrote on 06/08/2004 02:49:41 PM:
> >
> > After 50% of the patch I grew tired of it.  Martin, since when do you
> > like excessive use of #ifdef?
> 
> Well, it isn't so bad. Only 35 #ifdef CONFIG_QDIO_DEBUG.

Maybe our definitions of "isn't so bad" don't match. ;)
Anyway, it's a first step.  No new code was added, the old debugging
mess is explicitly marked as such now.  Next step would be to either
completely get rid of it or replace it with something less ugly.

Jörn

-- 
Beware of bugs in the above code; I have only proved it correct, but
not tried it.
-- Donald Knuth

      parent reply	other threads:[~2004-08-06 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-05 13:14 Martin Schwidefsky
2004-08-06 12:49 ` Jörn Engel
     [not found]   ` <OFECABF5A6.F2037B97-ON42256EE8.00472EEA-42256EE8.0047790E@de.ibm.com>
2004-08-06 13:09     ` Jörn Engel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040806130942.GB2065@wohnheim.fh-wedel.de \
    --to=joern@wohnheim.fh-wedel.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®