Re: [PATCH] Re-implemented i586 asm AES

[Marc Ballarin <Ballarin.Marc@gmx.de>]

On Fri, 6 Aug 2004 04:24:08 -0400 (EDT)
James Morris <jmorris@redhat.com> wrote:

> This code is a rework of the original Gladman AES code, and does not
> include any supposed BSD licensed work by Jari Ruusu.
> 

Will this code work with CONFIG_REGPARM=y ?

> +
> +// An AES (Rijndael) implementation for the Pentium MMX family using
> the NASM+// assembler <http://www.web-sites.co.uk/nasm/>. This version
> only implements+// the standard AES block length (128 bits, 16 bytes)
> with the same interface+// as that used in my C/C++ implementation.  
> This code does not preserve the+// eax, ecx or edx registers or the
> artihmetic status flags. However, the ebx, +// esi, edi, and ebp
> registers are preserved across calls.    Only encryption+// and
> decryption are implemented here, the key schedule code being that
> from+// compiling aes.c with USE_ASM defined.  This code uses VC++
> register saving+// conentions// if it is used with another compiler, its
> conventions for using+// and saving registers will need to be checked.
> +

This comment seems partly obsolete.

>  config CRYPTO_AES
>  	tristate "AES cipher algorithms"
> -	depends on CRYPTO
> +	depends on CRYPTO && !(X86 && !X86_64)
>  	help

Does it work on x86 CPUs without MMX?

Regards