From: Pavel Machek <pavel@suse.cz>
To: Patrick Mochel <mochel@digitalimplant.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [14/25] Merge pmdisk and swsusp
Date: Fri, 6 Aug 2004 21:31:48 +0200 [thread overview]
Message-ID: <20040806193148.GH3048@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.50.0408012131490.25060-100000@monsoon.he.net>
Hi!
> > Moving #ifdef inside function will result with a little less code...
>
> Actually, we should change them to pr_debug(), like below. And, how about
> makin it a config option, so one does not have to go around editing source
> files to turn on the extra messages?
Looks okay, but I'm not sure if Andrew/Linus will like new config
option. pr_debug() change is nice.
> BTW, many of those printk()s could use some editing to make them
> meaningful to average user. ;)
Hmm, yes, that will have to happen... There's one more problem: it
usually flashes for so short period that its impossible to read. Do
you use serial console or high-speed camera :-)?
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-08-06 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-17 22:35 Patrick Mochel
2004-07-18 22:18 ` Pavel Machek
2004-08-02 4:33 ` Patrick Mochel
2004-08-06 19:31 ` Pavel Machek [this message]
2004-07-18 22:19 ` Pavel Machek
2004-08-02 4:55 ` Patrick Mochel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040806193148.GH3048@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®