From: viro@parcelfarce.linux.theplanet.co.uk
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH: fix some 32bit isms
Date: Sat, 7 Aug 2004 00:03:05 +0100 [thread overview]
Message-ID: <20040806230305.GW12308@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <cf125u$hnt$1@terminus.zytor.com>
On Fri, Aug 06, 2004 at 10:53:50PM +0000, H. Peter Anvin wrote:
> Followup to: <20040728092334.74e0cfcd.akpm@osdl.org>
> By author: Andrew Morton <akpm@osdl.org>
> In newsgroup: linux.dev.kernel
> >
> > Alan Cox <alan@redhat.com> wrote:
> > >
> > > printk(MYIOC_s_ERR_FMT
> > > "Invalid IOC facts reply, msgLength=%d offsetof=%d!\n",
> > > - ioc->name, facts->MsgLength, (offsetof(IOCFactsReply_t,
> > > + ioc->name, facts->MsgLength, (int)(offsetof(IOCFactsReply_t,
> >
> > printk expects %zd for a size_t
> >
>
> It should be %zu, since size_t is unsigned.
>
> %zd is appropriate for ssize_t.
It's signed (and not a ssize_t, while we are at it). If you want to be
pedantic, use %td since we are dealing with ptrdiff_t here.
BTW, we ought to add 't' modifier in vsnpritf()...
next prev parent reply other threads:[~2004-08-06 23:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 13:59 Alan Cox
2004-07-28 15:42 ` H. Peter Anvin
2004-07-28 15:51 ` David S. Miller
2004-07-28 16:23 ` Andrew Morton
2004-07-28 16:27 ` Alan Cox
2004-08-06 22:53 ` H. Peter Anvin
2004-08-06 23:03 ` viro [this message]
2004-08-06 23:07 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040806230305.GW12308@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®