From: Sam Ravnborg <sam@ravnborg.org>
To: Sam Ravnborg <sam@ravnborg.org>,
Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix kallsyms dependency
Date: Sun, 8 Aug 2004 17:46:10 +0200 [thread overview]
Message-ID: <20040808154610.GA18740@mars.ravnborg.org> (raw)
In-Reply-To: <20040808123230.B7589@flint.arm.linux.org.uk>
On Sun, Aug 08, 2004 at 12:32:30PM +0100, Russell King wrote:
> Hi,
>
> It appears that kallsyms data is not updated if the kallsyms program is
> changed. The following patch adds an appropriate dependency.
Added, and implemented your suggestion in scripts/Makefile
with a few other CONFIG selections.
Btw. any specific reason to hack kallsyms? Just curious if something
shows up in this area.
Patch added for reference.
Sam
===== Makefile 1.510 vs edited =====
--- 1.510/Makefile 2004-08-07 21:35:27 +02:00
+++ edited/Makefile 2004-08-08 17:26:49 +02:00
@@ -584,7 +584,7 @@
.tmp_kallsyms1.o .tmp_kallsyms2.o .tmp_kallsyms3.o: %.o: %.S scripts FORCE
$(call if_changed_dep,as_o_S)
-.tmp_kallsyms%.S: .tmp_vmlinux%
+.tmp_kallsyms%.S: .tmp_vmlinux% $(KALLSYMS)
$(call cmd,kallsyms)
.tmp_vmlinux1: $(vmlinux-objs) arch/$(ARCH)/kernel/vmlinux.lds.s FORCE
===== scripts/Makefile 1.40 vs edited =====
--- 1.40/scripts/Makefile 2004-07-23 01:27:54 +02:00
+++ edited/scripts/Makefile 2004-08-08 17:31:59 +02:00
@@ -5,11 +5,14 @@
# docproc: Preprocess .tmpl file in order to generate .sgml docs
# conmakehash: Create arrays for initializing the kernel console tables
-host-progs := conmakehash kallsyms pnmtologo bin2c
+host-progs-$(CONFIG_KALLSYMS) += kallsyms
+host-progs-$(CONFIG_LOGO) += pnmtologo
+
+host-progs := $(host-progs-y) conmakehash bin2c
always := $(host-progs)
-subdir-$(CONFIG_MODVERSIONS) += genksyms
-subdir-y += mod
+subdir-$(CONFIG_MODVERSIONS) += genksyms
+subdir-$(CONFIG_MODULES) += mod
# Let clean descend into subdirs
subdir- += basic lxdialog kconfig package
next prev parent reply other threads:[~2004-08-08 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-08 11:32 Russell King
2004-08-08 15:46 ` Sam Ravnborg [this message]
2004-08-08 15:54 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040808154610.GA18740@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome