From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S266237AbUHHTwH@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S266237AbUHHTwH (ORCPT <rfc822;willy@w.ods.org>);
	Sun, 8 Aug 2004 15:52:07 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266233AbUHHTwG
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sun, 8 Aug 2004 15:52:06 -0400
Received: from gprs214-77.eurotel.cz ([160.218.214.77]:7552 "EHLO amd.ucw.cz")
	by vger.kernel.org with ESMTP id S266214AbUHHTuh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 8 Aug 2004 15:50:37 -0400
Date: Sun, 8 Aug 2004 21:50:21 +0200
From: Pavel Machek <pavel@ucw.cz>
To: Sven-Haegar Koch <haegar@sdinet.de>
Cc: Dave Jones <davej@codemonkey.org.uk>,
       Linux-Kernel-Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: Suspend/Resume support for ati-agp
Message-ID: <20040808195021.GB7765@elf.ucw.cz>
References: <Pine.LNX.4.58.0408080331490.15568@mercury.sdinet.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.58.0408080331490.15568@mercury.sdinet.de>
X-Warning: Reading this can be dangerous to your mental health.
User-Agent: Mutt/1.5.5.1+cvs20040105i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

> while trying to debug a strange resume problem with 2.6.8-rc3-mm1 and
> software suspend 2 I suspeced ati-agp, and created the following attached
> patch to add powermanagement support for it.
> 
> I don't know if it's the completely right thing to do, I just copied the
> way via-agp and intel-agp do it - but perhaps you like it and want to send
> it upstream.

Looks good to me.

> ps:
> this did not fix the strange "weird vertical bars instead of movie in
> mplayer after resume" I have, but does not do any bad things either
> ;)

Hmm, and does it fix anything?

									Pavel


> --- linux/drivers/char/agp/ati-agp.c.orig	2004-08-08 02:53:10.000000000 +0200
> +++ linux/drivers/char/agp/ati-agp.c	2004-08-08 03:06:03.000000000 +0200
> @@ -505,6 +505,33 @@
>  	agp_put_bridge(bridge);
>  }
> 
> +#ifdef CONFIG_PM
> +
> +static int agp_ati_suspend(struct pci_dev *pdev, u32 state)
> +{
> +	pci_save_state (pdev, pdev->saved_config_space);
> +	pci_set_power_state (pdev, 3);
> +
> +	return 0;
> +}
> +
> +static int agp_ati_resume(struct pci_dev *pdev)
> +{
> +	struct agp_bridge_data *bridge = pci_get_drvdata(pdev);
> +
> +	/* set power state 0 and restore PCI space */
> +	pci_set_power_state (pdev, 0);
> +	pci_restore_state(pdev, pdev->saved_config_space);
> +
> +	/* reconfigure AGP hardware again */
> +	if (bridge->driver == &ati_generic_bridge)
> +		return ati_configure();
> +
> +	return 0;
> +}
> +
> +#endif /* CONFIG_PM */
> +
>  static struct pci_device_id agp_ati_pci_table[] = {
>  	{
>  	.class		= (PCI_CLASS_BRIDGE_HOST << 8),
> @@ -524,6 +551,10 @@
>  	.id_table	= agp_ati_pci_table,
>  	.probe		= agp_ati_probe,
>  	.remove		= agp_ati_remove,
> +#ifdef CONFIG_PM
> +	.suspend	= agp_ati_suspend,
> +	.resume		= agp_ati_resume,
> +#endif
>  };
> 
>  static int __init agp_ati_init(void)
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!