From: Andrew Morton <akpm@osdl.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: josha@sgi.com, linux-kernel@vger.kernel.org, steiner@sgi.com
Subject: Re: [PATCH] Reduce bkl usage in do_coredump
Date: Mon, 9 Aug 2004 11:13:06 -0700 [thread overview]
Message-ID: <20040809111306.2091858a.akpm@osdl.org> (raw)
In-Reply-To: <1092072631.6496.14553.camel@nighthawk>
Dave Hansen <haveblue@us.ibm.com> wrote:
>
> > - format_corename(corename, core_pattern, signr);
> > + /*
> > + * lock_kernel() because format_corename() is controlled by sysctl, which
> > + * uses lock_kernel()
> > + */
> > + lock_kernel();
> > + format_corename(corename, core_pattern, signr);
> > + unlock_kernel();
>
> Might be nicer to just put the locking inside of format_corename() if it
> is the function itself that really needs the locking.
Nope. format_corename() just takes a char *. It has no knowledge about
what that char*'s locking rules are. It's the caller who chose to use a
char* which is protected by lock_kernel().
prev parent reply other threads:[~2004-08-09 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 14:38 Josh Aas
2004-08-09 17:30 ` Dave Hansen
2004-08-09 17:45 ` Josh Aas
2004-08-09 18:13 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040809111306.2091858a.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=josha@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome