From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Andrew Morton <akpm@osdl.org>
Cc: ehm@cris.com, grif@cs.ucr.edu, linux-kernel@vger.kernel.org
Subject: [PATCH] QLogic ISP2x00: remove needless busyloop
Date: Mon, 9 Aug 2004 12:52:58 -0600 [thread overview]
Message-ID: <200408091252.58547.bjorn.helgaas@hp.com> (raw)
There's no need to wait for an isp2x00 to recognize a fabric if
there's no isp2x00. Probably nobody will notice the unnecessary
slowdown on real hardware, but it's a significant delay on a
simulator.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com.
===== drivers/scsi/qlogicfc.c 1.44 vs edited =====
--- 1.44/drivers/scsi/qlogicfc.c 2004-06-06 05:17:21 -06:00
+++ edited/drivers/scsi/qlogicfc.c 2004-08-09 12:23:06 -06:00
@@ -815,9 +815,11 @@
some time before recognizing it is attached to a fabric */
#if ISP2x00_FABRIC
- for (wait_time = jiffies + 5 * HZ; time_before(jiffies, wait_time);) {
- barrier();
- cpu_relax();
+ if (hosts) {
+ for (wait_time = jiffies + 5 * HZ; time_before(jiffies, wait_time);) {
+ barrier();
+ cpu_relax();
+ }
}
#endif
next reply other threads:[~2004-08-09 18:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 18:52 Bjorn Helgaas [this message]
2004-08-09 20:03 ` Christoph Hellwig
2004-08-09 20:19 ` Bjorn Helgaas
2004-08-09 20:21 ` Christoph Hellwig
2004-08-09 21:08 ` Bjorn Helgaas
2004-08-09 21:16 ` Christoph Hellwig
2004-08-09 21:11 ` David S. Miller
2004-08-09 21:15 ` Christoph Hellwig
2004-08-09 21:20 ` David S. Miller
2004-08-09 21:27 ` Christoph Hellwig
2004-08-09 21:16 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408091252.58547.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=akpm@osdl.org \
--cc=ehm@cris.com \
--cc=grif@cs.ucr.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®