From: Sam Ravnborg <sam@ravnborg.org>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org,
viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: [RFC] Host Virtual Serial Interface driver
Date: Mon, 9 Aug 2004 21:00:42 +0200 [thread overview]
Message-ID: <20040809190042.GB20397@mars.ravnborg.org> (raw)
In-Reply-To: <200408091351.49211.hollisb@us.ibm.com>
On Mon, Aug 09, 2004 at 01:51:49PM -0500, Hollis Blanchard wrote:
> >
> > pr_debug is a noop if DEBUG is not defined. Make dump_hex, dump_packet
> > be a noop also and you get rid of several #ifdef in the code.
>
> I'd like to do that, but notice that dump_hex() is called from dump_packet()
> from hvsi_recv_response() (and I've just made hvsi_recv_control() the same).
> Even with debug disabled, I'd like to be able to dump a whole packet if I get
> confused...
Make a small wrapper that becomes noop in non-debug case,
and use the real one where you do not care about DEBUG.
Sam
next prev parent reply other threads:[~2004-08-09 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-06 21:23 Hollis Blanchard
2004-08-09 17:51 ` Randy.Dunlap
2004-08-09 18:46 ` Hollis Blanchard
2004-08-09 18:48 ` Sam Ravnborg
2004-08-09 18:51 ` Hollis Blanchard
2004-08-09 19:00 ` Sam Ravnborg [this message]
2004-08-09 19:08 ` Hollis Blanchard
2004-08-09 19:12 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040809190042.GB20397@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=hollisb@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®