From: Adrian Bunk <bunk@fs.tum.de>
To: achim_leubner@adaptec.com
Cc: James.Bottomley@SteelEye.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: [2.6 patch] SCSI gdth: kill #define __devinitdata
Date: Mon, 9 Aug 2004 21:41:05 +0200 [thread overview]
Message-ID: <20040809194105.GW26174@fs.tum.de> (raw)
I got the following warning in 2.6.8-rc3-mm2:
<-- snip -->
...
CC drivers/scsi/gdth.o
drivers/scsi/gdth.c:622:1: warning: "__devinitdata" redefined
In file included from include/linux/moduleparam.h:4,
from include/linux/module.h:20,
from drivers/scsi/gdth.c:375:
include/linux/init.h:227:1: warning: this is the location of the
previous definition
...
<-- snip -->
The #define in question seems bogus, and the following patch simply
removes it:
Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
--- linux-2.6.8-rc3-mm2-full-3.4/drivers/scsi/gdth.c.old 2004-08-09 20:59:07.000000000 +0200
+++ linux-2.6.8-rc3-mm2-full-3.4/drivers/scsi/gdth.c 2004-08-09 21:03:02.000000000 +0200
@@ -618,9 +618,6 @@
};
/* __initfunc, __initdata macros */
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
-#define __devinitdata
-#endif
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)
#define GDTH_INITFUNC(type, func) type __init func
#include <linux/init.h>
reply other threads:[~2004-08-09 19:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040809194105.GW26174@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=James.Bottomley@SteelEye.com \
--cc=achim_leubner@adaptec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®