From: Tomas Szepe <szepe@pinerecords.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Jeff Chua <jeffchua@silk.corp.fedex.com>,
netdev@oss.sgi.com, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: ipw2100 wireless driver
Date: Mon, 9 Aug 2004 22:15:56 +0200 [thread overview]
Message-ID: <20040809201556.GB9677@louise.pinerecords.com> (raw)
In-Reply-To: <20040714115523.GC2269@elf.ucw.cz>
On Jul-14 2004, Wed, 13:55 +0200
Pavel Machek <pavel@suse.cz> wrote:
> > >What is the status of ipw2100? Is there chance that it would be pushed
> > >into mainline?
> > >
> > >I have few problems with that:
> > >
> > >* it will not compile with gcc-2.95. Attached patch fixes one problem
> > >but more remain.
> >
> > I've given up hope on that. Don't think it'll ever compile on 2.95. I'm
> > using ndiswrapper and it works nicely.
>
> No, I think that can be fixed... I'll rather fix ipw2100 than use
> ndiswrapper.
ipw2100 0.51 from ipw2100.sf.net builds using gcc-2.95.3 "out of the box."
Also make sure to use the attached patch for 2.6.8pre.
--
Tomas Szepe <szepe@pinerecords.com>
diff -urN linux-2.6.7/drivers/net/wireless/ipw2100/ipw2100_fw.c linux-2.6.7.x/drivers/net/wireless/ipw2100/ipw2100_fw.c
--- linux-2.6.7/drivers/net/wireless/ipw2100/ipw2100_fw.c 2004-08-09 21:37:11.000000000 +0200
+++ linux-2.6.7.x/drivers/net/wireless/ipw2100/ipw2100_fw.c 2004-08-09 21:36:15.000000000 +0200
@@ -200,7 +200,7 @@
goto fail;
}
- if (read(fd, c->buf, c->len) != c->len) {
+ if (sys_read(fd, c->buf, c->len) != c->len) {
printk(KERN_INFO "Failed to read chunk firmware "
"chunk %d.\n", i);
goto fail;
@@ -231,17 +231,17 @@
INIT_LIST_HEAD(&fw->fw.chunk_list);
INIT_LIST_HEAD(&fw->uc.chunk_list);
- fd = open(fn, 0, 0);
+ fd = sys_open(fn, 0, 0);
if (fd == -1) {
printk(KERN_INFO "Unable to load '%s'.\n", fn);
return 1;
}
- l = lseek(fd, 0L, 2);
- lseek(fd, 0L, 0);
+ l = sys_lseek(fd, 0L, 2);
+ sys_lseek(fd, 0L, 0);
IPW2100_DEBUG_FW("Loading %ld bytes for firmware '%s'\n", l, fn);
- if (read(fd, (char *)&h, sizeof(h)) != sizeof(h)) {
+ if (sys_read(fd, (char *)&h, sizeof(h)) != sizeof(h)) {
printk(KERN_INFO "Failed to read '%s'.\n", fn);
goto fail;
}
@@ -262,12 +262,12 @@
if (ipw2100_fw_load(fd, &fw->uc, h.uc_size))
goto fail;
- close(fd);
+ sys_close(fd);
return 0;
fail:
ipw2100_fw_free(fw);
- close(fd);
+ sys_close(fd);
return 1;
}
next prev parent reply other threads:[~2004-08-09 20:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 11:41 Pavel Machek
2004-07-14 11:48 ` Jeff Chua
2004-07-14 11:55 ` Pavel Machek
2004-07-14 14:53 ` Éric Brunet
2004-07-14 15:24 ` Emiliano 'AlberT' Gabrielli
2004-08-09 20:15 ` Tomas Szepe [this message]
2004-08-10 5:02 ` Jeff Chua
2004-08-10 6:55 ` Christoph Hellwig
2004-08-10 10:16 ` Pavel Machek
2004-08-10 10:34 ` Christoph Hellwig
2004-08-11 12:17 ` Pavel Machek
2004-08-11 17:54 ` Jeff Garzik
2004-08-11 20:27 ` Pavel Machek
2004-08-11 22:01 ` Jeff Garzik
2004-08-11 10:16 ` James Ketrenos
2004-08-11 10:44 ` Christoph Hellwig
2004-08-11 10:53 ` Wichert Akkerman
2004-08-11 10:59 ` Christoph Hellwig
2004-08-11 16:21 ` James Ketrenos
2004-08-11 16:30 ` Stephen Hemminger
2004-08-11 16:33 ` Tomas Szepe
2004-08-11 16:51 ` Christoph Hellwig
2004-08-11 17:02 ` Tomas Szepe
2004-08-11 17:11 ` Christoph Hellwig
2004-08-11 17:22 ` Tomas Szepe
2004-08-11 17:41 ` Christoph Hellwig
2004-08-11 17:51 ` Tomas Szepe
2004-08-11 22:43 ` David Woodhouse
2004-08-11 22:56 ` Tomas Szepe
2004-08-11 23:06 ` David Woodhouse
2004-08-11 23:11 ` Tomas Szepe
2004-08-11 23:21 ` David Woodhouse
2004-08-11 18:55 ` John Stoffel
2004-08-11 23:55 ` Jeff Chua
2004-08-12 3:47 ` Luis R. Rodriguez
2004-08-11 17:51 ` Jeff Garzik
2004-07-14 12:30 ` Tomas Szepe
2004-07-14 12:27 ` Pavel Machek
2004-07-14 13:15 ` Vojtech Pavlik
2004-07-14 13:42 ` Pavel Machek
2004-07-14 17:00 ` Victor J. Orlikowski
[not found] <2hQr1-62p-23@gated-at.bofh.it>
[not found] ` <2hRQ5-7bn-9@gated-at.bofh.it>
2004-07-14 14:07 ` Andi Kleen
2004-07-14 14:59 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040809201556.GB9677@louise.pinerecords.com \
--to=szepe@pinerecords.com \
--cc=jeffchua@silk.corp.fedex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®