mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Vasquez <praka@pobox.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: 2.6.8-rc3-mm2:  Debug: sleeping function called from invalid context at mm/mempool.c:197
Date: Mon, 9 Aug 2004 13:58:39 -0700	[thread overview]
Message-ID: <20040809205839.GA1439@praka.san.rr.com> (raw)
In-Reply-To: <411813F0.9020602@us.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

On Mon, 09 Aug 2004, Janet Morgan wrote:

> Andrew Vasquez wrote:
> 
> >
> >This allocation should be done with GFP_ATOMIC flags.  The attached 
> >patch should apply cleanly to any recent kernel
> >
> > 
> >
> 
> and seems to work fine.
> 

James,


I hope this patch can make it before 2.6.8, please apply.



Thanks,
Andrew Vasquez

[-- Attachment #2: mpool_alloc.diff --]
[-- Type: text/plain, Size: 392 bytes --]

===== drivers/scsi/qla2xxx/qla_os.c 1.39 vs edited =====
--- 1.39/drivers/scsi/qla2xxx/qla_os.c	2004-07-12 09:54:49 -07:00
+++ edited/drivers/scsi/qla2xxx/qla_os.c	2004-08-09 16:48:29 -07:00
@@ -3590,7 +3590,7 @@
 {
 	srb_t *sp;
 
-	sp = mempool_alloc(ha->srb_mempool, GFP_KERNEL);
+	sp = mempool_alloc(ha->srb_mempool, GFP_ATOMIC);
 	if (sp)
 		atomic_set(&sp->ref_count, 1);
 	return (sp);

  reply	other threads:[~2004-08-10  4:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-09 23:56 Andrew Vasquez
2004-08-10  0:16 ` Janet Morgan
2004-08-09 20:58   ` Andrew Vasquez [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-08-09 13:41 Janet Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040809205839.GA1439@praka.san.rr.com \
    --to=praka@pobox.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®