Hi Andi, On Wed, Aug 11, 2004 at 06:36:16PM +0200, Andi Kleen wrote: > Prasanna S Panchamukhi writes: > > Just some cosmetical comments. > > > > > +EXPORT_SYMBOL(register_die_chain_notify); > > Please name it "register_die_notifier" > > > > > static int kstack_depth_to_print = 24; > > +struct notifier_block *i386die_chain; > > +static DECLARE_MUTEX(i386die_chain_mutex); > > s/i386// > > I don't know why you made this a mutex, a spinlock would > be fine too. But that's a minor issue. > I have modified the patch as per your comments. Please let me know if you any issues. Thanks Prasanna -- Prasanna S Panchamukhi Linux Technology Center India Software Labs, IBM Bangalore Ph: 91-80-25044636