mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Paul Blazejowski <diffie@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, "Randy.Dunlap" <rddunlap@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.8-rc4-mm1
Date: Thu, 12 Aug 2004 17:21:46 -0600	[thread overview]
Message-ID: <200408121721.46807.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <9dda3492040812114929cf8dcc@mail.gmail.com>

On Thursday 12 August 2004 12:49 pm, Paul Blazejowski wrote:
> I managed to caputre the serial console output of the boot process
> with the error. Below is the full log.

Thank you very much for the pictures and the transcript.  I found a
couple bugs in the iteraid driver.  Could you please try the attached
patch?

--- 2.6.8-rc4-mm1/drivers/scsi/iteraid.h.orig	2004-08-12 16:50:38.483419878 -0600
+++ 2.6.8-rc4-mm1/drivers/scsi/iteraid.h	2004-08-12 17:16:08.569338635 -0600
@@ -1203,8 +1203,8 @@
 typedef struct _Adapter {
 	char *name;		/* Adapter's name               */
 	u8 num_channels;	/* How many channels support    */
-	u8 irq;			/* irq number                   */
-	u8 irqOwned;		/* If any irq is use            */
+	unsigned int irq;	/* irq number                   */
+	unsigned int irqOwned;	/* If any irq is use            */
 	u8 pci_bus;		/* PCI bus number               */
 	u8 devfn;		/* Device and function number   */
 	u8 offline;		/* On line or off line          */
--- 2.6.8-rc4-mm1/drivers/scsi/iteraid.c.orig	2004-08-12 16:43:38.700221895 -0600
+++ 2.6.8-rc4-mm1/drivers/scsi/iteraid.c	2004-08-12 17:18:19.419922969 -0600
@@ -4798,6 +4798,7 @@
 			       pAdap->name);
 			return -1;
 		}
+		printk("%s: IRQ %d for device at %s\n", __FUNCTION__, pAdap->irq, pci_name(pPciDev));
 		pAdap->irqOwned = pAdap->irq;
 	}
 
@@ -4901,12 +4902,17 @@
 		if (PCI_FUNC(pPciDev->devfn))
 			continue;
 
+		if (pci_enable_device(pPciDev))
+			continue;
+
+		printk("%s: device at %s\n", __FUNCTION__, pci_name(pPciDev));
 		/*
 		 * Allocate memory for Adapter.
 		 */
 		pAdap = (PITE_ADAPTER) kmalloc(sizeof(ITE_ADAPTER), GFP_ATOMIC);
 		if (pAdap == NULL) {
 			printk("iteraid_detect: pAdap allocate failed.\n");
+			pci_disable_device(pPciDev);
 			continue;
 		}
 		memset(pAdap, 0, sizeof(ITE_ADAPTER));
@@ -5016,6 +5022,7 @@
 		if (pAdap->IDEChannel != NULL) {
 			kfree(pAdap->IDEChannel);
 		}
+		pci_disable_device(pAdap->pci_dev);
 		if (pAdap != NULL) {
 			kfree(pAdap);
 		}

  reply	other threads:[~2004-08-12 23:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-12 18:49 2.6.8-rc4-mm1 Paul Blazejowski
2004-08-12 23:21 ` Bjorn Helgaas [this message]
2004-08-13  8:15   ` 2.6.8-rc4-mm1 Paul Blazejowski
  -- strict thread matches above, loose matches on Subject: below --
2004-08-11  3:33 2.6.8-rc4-mm1 Diffie
2004-08-11 15:36 ` 2.6.8-rc4-mm1 Randy.Dunlap
2004-08-11 22:57 ` 2.6.8-rc4-mm1 Bjorn Helgaas
2004-08-12  5:48   ` 2.6.8-rc4-mm1 Paul Blazejowski
2004-08-10 18:38 2.6.8-rc4-mm1 Diffie
2004-08-10  7:21 2.6.8-rc4-mm1 Andrew Morton
2004-08-10 16:37 ` 2.6.8-rc4-mm1 Jesse Barnes
2004-08-10 21:20   ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:39     ` 2.6.8-rc4-mm1 Robert Picco
2004-08-10 22:28       ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:30         ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:43           ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:45             ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 23:03               ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 23:38                 ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-11  2:01                 ` 2.6.8-rc4-mm1 Jesse Barnes
2004-08-10 23:15       ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-11  0:12 ` 2.6.8-rc4-mm1 Tom Vier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200408121721.46807.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=akpm@osdl.org \
    --cc=diffie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®