From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: IDE hackery: lock fixes and hotplug controller stuff
Date: Thu, 12 Aug 2004 19:12:35 +0200 [thread overview]
Message-ID: <200408121912.35507.bzolnier@elka.pw.edu.pl> (raw)
In-Reply-To: <20040810182353.GA17364@devserv.devel.redhat.com>
On Tuesday 10 August 2004 20:23, Alan Cox wrote:
> On Tue, Aug 10, 2004 at 07:16:17PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Tuesday 10 August 2004 18:19, Alan Cox wrote:
> > > - Remove unsafe and essentially unfixable proc code for flipping
> > > between ide-cd and ide-scsi. Its no longer relevant with SG_IO.
> >
> > Shouldn't we deprecate it first...?
>
> It doesn't work now so it clearly isnt being used 8). We hold the lock
> because its a proc function and we then replace the proc functions in the
> attach method -> deadlock. It is also incredibly hard to fix without a
> major rewrite.
It is a correct analysis for /proc/ide/hdx/settings:ide-scsi but not
for /proc/ide/hdx/driver which works just fine (modulo being racy)
and your patch removes both interfaces...
Bartlomiej
next prev parent reply other threads:[~2004-08-12 18:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-10 16:19 Alan Cox
2004-08-10 17:16 ` Bartlomiej Zolnierkiewicz
2004-08-10 18:23 ` Alan Cox
2004-08-12 17:12 ` Bartlomiej Zolnierkiewicz [this message]
2004-08-12 18:56 ` Alan Cox
2004-08-12 19:46 ` Bartlomiej Zolnierkiewicz
2004-08-12 20:37 ` Alan Cox
2004-08-10 20:48 ` Ian Hastie
2004-08-10 21:06 ` Alan Cox
2004-08-11 0:36 ` Ian Hastie
2004-08-12 19:55 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408121912.35507.bzolnier@elka.pw.edu.pl \
--to=b.zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®