From: Pete Zaitcev <zaitcev@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Neil Horman <nhorman@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mike_phillips@urscorp.com, zaitcev@redhat.com
Subject: Re: [Patch} to fix oops in olympic token ring driver on media disconnect
Date: Fri, 13 Aug 2004 16:35:27 -0700 [thread overview]
Message-ID: <20040813163527.17aec0b5@lembas.zaitcev.lan> (raw)
In-Reply-To: <1092434830.25002.25.camel@localhost.localdomain>
On Fri, 13 Aug 2004 23:07:16 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Gwe, 2004-08-13 at 20:11, Neil Horman wrote:
> > the olympic_close routine was waiting on. This patch cleans that up.
> >
> > Tested by me, on 2.4 and 2.6 with good, working results, and no more oopses.
>
> Should it not be blocking the IRQs on the chip as well ?
I assumed that old olympic_close() did, but perhaps it didn't after all.
There is nothing like the following in it:
+#define DISABLE_IRQS(base_addr) do { \
+ writel(LISR_LIE,(base_addr)+LISR_RWM);\
+ writel(SISR_MI,(base_addr)+SISR_RWM);\
+} while(0)
This is curious. If something was never used, how do we know if it works?
Maybe it's safer just to leave things as Neil did.
-- Pete
next prev parent reply other threads:[~2004-08-13 23:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-13 19:11 Neil Horman
2004-08-13 22:07 ` Alan Cox
2004-08-13 23:35 ` Pete Zaitcev [this message]
2004-08-13 23:48 ` Jeff Garzik
2004-08-14 0:06 ` Neil Horman
2004-08-16 15:10 ` Mike_Phillips
2004-08-16 15:18 ` Jeff Garzik
2004-08-17 0:08 ` Pete Zaitcev
2004-08-17 0:42 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040813163527.17aec0b5@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mike_phillips@urscorp.com \
--cc=nhorman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®