From: viro@parcelfarce.linux.theplanet.co.uk
To: "Sebastian Kügler" <sebas@vizZzion.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Compile fixes for various fb drivers
Date: Sun, 15 Aug 2004 08:54:16 +0100 [thread overview]
Message-ID: <20040815075416.GC12308@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <200408150149.14663.sebas@vizZzion.org>
On Sun, Aug 15, 2004 at 01:49:13AM +0200, Sebastian Kügler wrote:
> Hi,
>
> fb_copy_cmap has changed in 2.6.8.1, but the change is not reflected in all
> drivers, this updates the respective framebuffer drivers.
>
> The patch is against vanilla 2.6.8.1.
>
> Signed-off-by: Sebastian Kügler <sebas@vizZzion.org>
NAK.
First of all, that compile fix isn't - try to compile these drivers and see
if any got fixed by that.
While we are at it, if they would compile, you would have broken them.
Question: what do you think the argument in question was controlling
and why would "drop it silently" be a correct fix?
And finally, the reason why these drivers would fail to compile for quite
a while has a lot in common with the reason why they call fb_copy_cmap()
in the first place - they are trying to provide a method that doesn't exist
anymore and calls in question are from the instances of that method. Fixing
that is going to remove these calls anyway.
next prev parent reply other threads:[~2004-08-15 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-14 23:49 Sebastian Kügler
2004-08-15 7:54 ` viro [this message]
2004-08-15 8:06 Sebastian Kügler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040815075416.GC12308@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=sebas@vizZzion.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®