From: Sam Ravnborg <sam@ravnborg.org>
To: Pavel Roskin <proski@gnu.org>
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] Bogus "has no CRC" in external module builds
Date: Sun, 15 Aug 2004 21:18:39 +0200 [thread overview]
Message-ID: <20040815191839.GE7682@mars.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0404291246220.7129@marabou.research.att.com>
On Thu, Apr 29, 2004 at 02:45:30PM -0400, Pavel Roskin wrote:
> Hello!
>
> The recent fixes for the external module build have fixed the major
> breakage, but they left one annoyance unfixed. If CONFIG_MODVERSIONS is
> disabled, a warning is printed for every exported symbol that is has no
> CRC. For instance, I see this when compiling the standalone Orinoco
> driver on Linux 2.6.6-rc3:
>
> *** Warning: "__orinoco_down" [/usr/local/src/orinoco/spectrum_cs.ko] has
> no CRC!
> *** Warning: "hermes_struct_init" [/usr/local/src/orinoco/spectrum_cs.ko]
> has no CRC!
> *** Warning: "free_orinocodev" [/usr/local/src/orinoco/spectrum_cs.ko] has
> no CRC!
> [further warnings skipped]
>
> I have found that the "-i" option for modpost is used for external builds,
> whereas the internal modules use "-o". The "-i" option causes read_dump()
> in modpost.c to be called. This function sets "modversions" variable
> under some conditions that I don't understand. The comment before the
> modversions declarations says: "Are we using CONFIG_MODVERSIONS?"
>
> Apparently modpost fails to answer this question. I think it's better to
> use an explicit option rather than a kludge.
>
> The attached patch adds a new option "-m" that is specified if and only if
> CONFIG_MODVERSIONS is enabled. The patch has been successfully tested
> both with and without CONFIG_MODVERSIONS.
Applied a handedited version of this to my tree - sorry for the dealy.
Sam
prev parent reply other threads:[~2004-08-15 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-29 18:45 Pavel Roskin
2004-08-15 19:18 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040815191839.GE7682@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®