From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, akpm@zip.com.au,
mochel@digitalimplant.org, benh@kernel.crashing.org,
david-b@pacbell.net
Subject: Re: [patch] enums to clear suspend-state confusion
Date: Mon, 16 Aug 2004 08:25:23 +0200 [thread overview]
Message-ID: <20040816062523.GB30338@elf.ucw.cz> (raw)
In-Reply-To: <20040815175949.19d03e7f.akpm@osdl.org>
Hi!
> > +enum pci_state {
> > + D0 = 0,
> > + D1 = 1,
> > + D2 = 2,
>
> These symbols are too generic. They don't appear to currently clash with
> anything else, but they could.
Actually jffs is using macros called D1, D2 and D3. Ouch. This one
should fix it.
Pavel
--- linux-forakpm/include/linux/pci.h 2004-08-15 19:35:41.000000000 +0200
+++ linux/include/linux/pci.h 2004-08-16 08:15:59.000000000 +0200
@@ -1023,23 +1023,23 @@
#define PCIPCI_ALIMAGIK 32
enum pci_state {
- D0 = 0,
- D1 = 1,
- D2 = 2,
- D3hot = 3,
- D3cold = 4
+ PCI_D0 = 0,
+ PCI_D1 = 1,
+ PCI_D2 = 2,
+ PCI_D3hot = 3,
+ PCI_D3cold = 4
};
static inline enum pci_state to_pci_state(suspend_state_t state)
{
if (SUSPEND_EQ(state, PM_SUSPEND_ON))
- return D0;
+ return PCI_D0;
if (SUSPEND_EQ(state, PM_SUSPEND_STANDBY))
- return D1;
+ return PCI_D1;
if (SUSPEND_EQ(state, PM_SUSPEND_MEM))
- return D3hot;
+ return PCI_D3hot;
if (SUSPEND_EQ(state, PM_SUSPEND_DISK))
- return D3cold;
+ return PCI_D3cold;
BUG();
}
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-08-16 6:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-12 12:02 Pavel Machek
2004-08-16 0:59 ` Andrew Morton
2004-08-16 6:25 ` Pavel Machek [this message]
2004-08-16 14:09 ` Takashi Iwai
2004-08-16 20:11 ` Pavel Machek
2004-08-17 21:25 ` Pavel Machek
2004-08-17 22:27 ` Andrew Morton
2004-08-17 22:37 ` Pavel Machek
2004-08-17 23:12 ` Andrew Morton
2004-08-18 0:27 ` Pavel Machek
2004-08-18 2:04 ` Benjamin Herrenschmidt
2004-08-18 6:12 ` Pavel Machek
2004-08-18 6:55 ` Benjamin Herrenschmidt
2004-08-18 13:03 ` Pavel Machek
2004-08-18 14:29 ` Patrick Mochel
2004-08-18 15:17 ` David Brownell
2004-08-18 20:47 ` Pavel Machek
2004-08-18 17:31 ` Alan Cox
2004-08-18 18:28 ` David Brownell
2004-08-18 20:35 ` Pavel Machek
2004-08-18 6:26 ` Pavel Machek
2004-08-18 6:30 ` Andrew Morton
2004-08-18 10:22 ` Takashi Iwai
[not found] <566B962EB122634D86E6EE29E83DD808182C3774@hdsmsx403.hd.intel.com>
2004-08-19 5:59 ` Len Brown
2004-08-19 8:19 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040816062523.GB30338@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=akpm@zip.com.au \
--cc=benh@kernel.crashing.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®