From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268020AbUHPXXL (ORCPT ); Mon, 16 Aug 2004 19:23:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268021AbUHPXXL (ORCPT ); Mon, 16 Aug 2004 19:23:11 -0400 Received: from mion.elka.pw.edu.pl ([194.29.160.35]:932 "EHLO mion.elka.pw.edu.pl") by vger.kernel.org with ESMTP id S268020AbUHPXXG (ORCPT ); Mon, 16 Aug 2004 19:23:06 -0400 From: Bartlomiej Zolnierkiewicz To: Alan Cox Subject: Re: PATCH: switch ide-proc to use the ide_key functionality Date: Tue, 17 Aug 2004 01:22:29 +0200 User-Agent: KMail/1.6.2 Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, torvalds@osdl.org References: <20040815150414.GA12181@devserv.devel.redhat.com> <200408161724.09880.bzolnier@elka.pw.edu.pl> <20040816153011.GE10279@devserv.devel.redhat.com> In-Reply-To: <20040816153011.GE10279@devserv.devel.redhat.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200408170122.29669.bzolnier@elka.pw.edu.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Monday 16 August 2004 17:30, Alan Cox wrote: > On Mon, Aug 16, 2004 at 05:24:09PM +0200, Bartlomiej Zolnierkiewicz wrote: > > This patch removes write access to /proc/ide/hd?/driver without even > > mentioning this - IMHO we should deprecate it first. Such changes should > > be described (with rationale for them) at least in the changelog > > (or even better in Documentation/ide.txt). > > I thought we discussed this earlier - its essentially unfixable. You can > either have trivial /proc crashes, deadlocks on writing this file or lose > the feature (which nobody on the planet even knew about). I used this 'feature' few times and never experienced crash or deadlock but they are possible of course. > If you've got any ideas how to fix it then let me know. > > Agreed about adding it to Documentation/ide.txt I fully agreed on the change but not the way in which it's done. ;-)