mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Kurt Garloff <garloff@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bio_uncopy_user mem leak
Date: Tue, 17 Aug 2004 15:50:04 -0700	[thread overview]
Message-ID: <20040817155004.70ac4d9e.akpm@osdl.org> (raw)
In-Reply-To: <20040817155918.GA5312@tpkurt.garloff.de>

Kurt Garloff <garloff@suse.de> wrote:
>
> When using bounce buffers for SG_IO commands with unaligned 
> buffers in blk_rq_map_user(), we should free the pages from
> blk_rq_unmap_user() which calls bio_uncopy_user() for the 
> non-BIO_USER_MAPPED case. That function failed to free the
> pages for write requests.
> 
> So we leaked pages and you machine would go OOM. Rebooting 
> helped ;-)

Eureka.  Thanks.

This really should trigger a 2.6.8.2.  We'll see.


  parent reply	other threads:[~2004-08-17 22:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-17 15:59 Kurt Garloff
2004-08-17 21:08 ` Gene Heskett
2004-08-17 22:50 ` Andrew Morton [this message]
2004-08-19  7:16 ` Colin Leroy
2004-08-19  9:59 Greg Afinogenov
2004-08-19 11:07 ` Con Kolivas
2004-08-19 13:51   ` Chris Mason
2004-08-19 19:55     ` Kurt Garloff
2004-08-20  3:19       ` Con Kolivas
2004-08-20  6:31         ` Andrew Morton
2004-08-20 12:54           ` Kurt Garloff
2004-08-20 20:28           ` sandr8
2004-08-20  7:15         ` Greg Afinogenov
2004-08-20 12:46         ` Kurt Garloff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040817155004.70ac4d9e.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=garloff@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®