mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Shawn Starr <shawn.starr@rogers.com>
Cc: linux-kernel@vger.kernel.org, Cyrille Ch?p?lov <cyrille@chepelov.org>
Subject: Re: 2.6.8.1-mm1 broke USB driver with ACPI pci irq routing... info follows
Date: Wed, 18 Aug 2004 17:40:15 -0600	[thread overview]
Message-ID: <200408181740.15310.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200408172104.30280.shawn.starr@rogers.com>

Shawn and Cyrille, can you try the attached patch, please?  We were using
__initdata from a function that is no longer used only at boot-time.
I'm pretty sure this will fix Shawn's problem.  I don't know whether
it'll fix yours, Cyrille, but it might.

Andrew, I think this is clearly a bug independent of my other patches
in -mm, so could you apply this as well?


Make acpi_irq_penalty non-initdata, since it's used by the
non_init acpi_pci_link_allocate().  And make acpi_irq_penalty_init()
__init, since it is used only by the __init pci_acpi_init().

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

===== drivers/acpi/pci_link.c 1.31 vs edited =====
--- 1.31/drivers/acpi/pci_link.c	2004-08-04 13:55:16 -06:00
+++ edited/drivers/acpi/pci_link.c	2004-08-18 17:26:48 -06:00
@@ -448,7 +448,7 @@
 #define PIRQ_PENALTY_ISA_USED		(16*16*16*16*16)
 #define PIRQ_PENALTY_ISA_ALWAYS		(16*16*16*16*16*16)
 
-static int __initdata acpi_irq_penalty[ACPI_MAX_IRQS] = {
+static int acpi_irq_penalty[ACPI_MAX_IRQS] = {
 	PIRQ_PENALTY_ISA_ALWAYS,	/* IRQ0 timer */
 	PIRQ_PENALTY_ISA_ALWAYS,	/* IRQ1 keyboard */
 	PIRQ_PENALTY_ISA_ALWAYS,	/* IRQ2 cascade */
@@ -468,7 +468,7 @@
 			/* >IRQ15 */
 };
 
-int
+int __init
 acpi_irq_penalty_init(void)
 {
 	struct list_head	*node = NULL;

  reply	other threads:[~2004-08-18 23:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-17  6:57 Shawn Starr
2004-08-17 14:48 ` Bjorn Helgaas
2004-08-18  1:04   ` Shawn Starr
2004-08-18 23:40     ` Bjorn Helgaas [this message]
2004-08-19  1:43       ` Shawn Starr
     [not found] <566B962EB122634D86E6EE29E83DD808182C37A2@hdsmsx403.hd.intel.com>
2004-08-19  6:38 ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200408181740.15310.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=cyrille@chepelov.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn.starr@rogers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®