mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joshua Kwan <joshk@triplehelix.org>
To: linux-kernel@vger.kernel.org
Subject: config language shortcomings in 2.4
Date: Thu, 19 Aug 2004 00:12:29 -0700	[thread overview]
Message-ID: <20040819071229.GA7598@darjeeling.triplehelix.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]

Hello,

Recently the Debian kernel team has been discussing 2.4's configuration
system. We have a patched tg3.c which removes the firmware and adds a
dependency on CONFIG_FW_LOADER for cases where operation is impossible
without the firmware.

Initially, we changed this:

dep_tristate 'Broadcom Tigon3 support' CONFIG_TIGON3 $CONFIG_PCI

to this:

dep_tristate 'Broadcom Tigon3 support' CONFIG_TIGON3 $CONFIG_PCI $CONFIG_FW_LOADER

But this would still be selectable if CONFIG_FW_LOADER were not set at
all. Selecting it would not enable CONFIG_FW_LOADER either.

So, we tried this:

if [ "$CONFIG_FW_LOADER" != "n" -a "$CONFIG_EXPERIMENTAL" = "y" ]; then
   dep_tristate 'Broadcom Tigon3 support' CONFIG_TIGON3 $CONFIG_PCI $CONFIG_FW_LOADER
fi

and this STILL doesn't seem to work in the case that CONFIG_FW_LOADER
isn't set but CONFIG_EXPERIMENTAL is y.

Eventually we continued droning through the corner cases until reaching

if [ "$CONFIG_EXPERIMENTAL" = "y" -a \
     "$CONFIG_HOTPLUG" = "y" -a \
     "$CONFIG_FW_LOADER" = "y" -o "$CONFIG_FW_LOADER" = "m" -a \
     "$CONFIG_CRC32" = "y" -o "$CONFIG_CRC32" = "m" ]; then
       dep_tristate 'Broadcom Tigon3 support' CONFIG_TIGON3 $CONFIG_PCI $CONFIG_FW_LOADER $CONFIG_CRC32
fi

which finally has the desired effect.

But is there really no way to say

config TIGON3
       select FW_LOADER

in 2.4?

CONFIG_PCMCIA_ATMEL also suffers from this problem.

Any ideas? Is it just that the old Configure scripts suck?

-- 
Joshua Kwan

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 881 bytes --]

             reply	other threads:[~2004-08-19  7:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-19  7:12 Joshua Kwan [this message]
2004-08-19  7:28 ` Willy Tarreau
2004-08-24  5:04   ` Joshua Kwan
2004-08-24  5:19     ` Nigel Cunningham
2004-08-24 18:35     ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040819071229.GA7598@darjeeling.triplehelix.org \
    --to=joshk@triplehelix.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®