From: Andrew Morton <akpm@osdl.org>
To: "bradgoodman.com" <bkgoodman@bradgoodman.com>
Cc: Atul.Mukker@lsil.com, bgoodman@acopia.com,
linux-kernel@vger.kernel.org, marcelo@conectiva.com.br,
torvalds@osdl.org
Subject: Re: [PATCH] 2.6.8.1 MegaRAID Driver Race
Date: Mon, 23 Aug 2004 15:16:14 -0700 [thread overview]
Message-ID: <20040823151614.278a5ee4.akpm@osdl.org> (raw)
In-Reply-To: <200408232157.i7NLvmB30968@bradgoodman.com>
"bradgoodman.com" <bkgoodman@bradgoodman.com> wrote:
>
> [PATCH] 2.6.8.1 to LSI Logic MegaRAID Adapter - ioctl function calls
> mega_internal_command, which uses wait_event, which calls schedule.
> This means schedule() is called while big kernel_lock is held.
>
> Locks/Unlocks were done here because
>
> 1. There are a lot of return()s in the ioctl function to dodge.
> 2. mega_internal_command is also called by read and writes,
> which don't hold big kernel_lock
Calling schedule() inside lock_kernel() is legal.
It may, however, be wrong within the context of the particular caller
because schedule() will drop the lock. So new races might have been
introduced.
next prev parent reply other threads:[~2004-08-23 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-23 21:57 bradgoodman.com
2004-08-23 22:16 ` Andrew Morton [this message]
2004-08-28 19:15 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040823151614.278a5ee4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Atul.Mukker@lsil.com \
--cc=bgoodman@acopia.com \
--cc=bkgoodman@bradgoodman.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®