From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Terence Ripperda <tripperda@nvidia.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Michael Geithe <warpy@gmx.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mastergoon@gmail.com
Subject: Re: 2.6.8.1-mm2 (nvidia breakage)
Date: Tue, 24 Aug 2004 09:26:42 -0600 [thread overview]
Message-ID: <200408240926.42665.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <20040823190131.GC1303@hygelac>
On Monday 23 August 2004 1:01 pm, Terence Ripperda wrote:
> On Mon, Aug 23, 2004 at 09:30:18AM -0600, bjorn.helgaas@hp.com wrote:
> > Of course, the nvidia driver still won't work
> > because it's looking at pci_dev->irq before calling pci_enable_device(),
> > but that's a separate issue.
>
> as Alan pointed out, the video device is bios configured, so may not
> be hit by this. nonetheless, we've applied a patch along these lines
> to our internal codebase.
To be pedantically clear about this, looking at pci_dev->irq before
calling pci_enable_device() is *guaranteed* to fail, regardless of
what the BIOS does. So nvidia users will have to use "pci=routeirq"
until there's a new version of the nvidia driver.
Alan was specifically referring to the BAR configuration that may
be done by the BIOS.
I'm assuming your patch makes the driver call pci_enable_device()
before using either irq or BAR information. That's the best way
to future-proof the driver.
next prev parent reply other threads:[~2004-08-24 15:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040819092654.27bb9adf.akpm@osdl.org>
2004-08-19 16:51 ` Bjorn Helgaas
2004-08-19 17:53 ` Alan Cox
2004-08-19 21:51 ` Terence Ripperda
2004-08-19 22:03 ` Bjorn Helgaas
2004-08-19 22:22 ` Alan Cox
2004-08-19 22:58 ` Terence Ripperda
2004-08-20 15:53 ` Bjorn Helgaas
2004-08-20 16:24 ` Michael Geithe
2004-08-20 19:04 ` Terence Ripperda
2004-08-23 15:30 ` Bjorn Helgaas
2004-08-23 19:01 ` Terence Ripperda
2004-08-24 15:26 ` Bjorn Helgaas [this message]
2004-08-24 17:22 ` Terence Ripperda
2004-08-24 17:36 ` Roland Dreier
2004-08-24 22:03 ` Terence Ripperda
2004-08-24 22:35 ` 2.6.8.1-mm2 (nvidia breakage) [u] Martin Schlemmer [c]
2004-08-24 5:17 2.6.8.1-mm2 (nvidia breakage) Michael Geithe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408240926.42665.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mastergoon@gmail.com \
--cc=tripperda@nvidia.com \
--cc=warpy@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®