From: Jesse Barnes <jbarnes@engr.sgi.com>
To: linux-kernel@vger.kernel.org
Cc: sam@ravnborg.org
Subject: Re: [PATCH] fix cc-version breakage
Date: Tue, 24 Aug 2004 16:48:49 -0700 [thread overview]
Message-ID: <200408241648.49261.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <200408241642.21886.jbarnes@engr.sgi.com>
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
On Tuesday, August 24, 2004 4:42 pm, Jesse Barnes wrote:
> Looks like someone forgot to use $(shell ...) on the cc-version function?
Actually, this is a little nicer (look ma, no linewraps!) if we can make
gcc-version.sh executable.
Jesse
[-- Attachment #2: cc-version-fix-2.patch --]
[-- Type: text/plain, Size: 463 bytes --]
===== Makefile 1.522 vs edited =====
--- 1.522/Makefile 2004-08-23 23:59:52 -07:00
+++ edited/Makefile 2004-08-24 16:46:44 -07:00
@@ -279,8 +279,7 @@
# cc-version
# Usage gcc-ver := $(call cc-version $(CC))
-cc-version = $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh \
- $(if $(1), $(1), $(CC))
+cc-version = $(shell $(srctree)/scripts/gcc-version.sh $(if $(1), $(1), $(CC)))
# Look for make include files relative to root of kernel src
next prev parent reply other threads:[~2004-08-24 23:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-24 23:42 Jesse Barnes
2004-08-24 23:48 ` Jesse Barnes [this message]
2004-08-25 4:43 ` Sam Ravnborg
2004-08-25 4:59 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408241648.49261.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®