mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, thomas@undata.org
Subject: Re: [PATCH] Fix shared interrupt handling of SA_INTERRUPT and SA_SAMPLE_RANDOM
Date: Tue, 24 Aug 2004 20:45:08 -0700	[thread overview]
Message-ID: <20040824204508.3b31449f.akpm@osdl.org> (raw)
In-Reply-To: <s5heklxhjbg.wl@alsa2.suse.de>

Takashi Iwai <tiwai@suse.de> wrote:
>
> while the recent investation of latency issues, Thomas Charbonne
>  suggested that there is a long-standing bug in the irq handler.
>  When the irq is shared, SA_INTERRUPT flag is checked only for the
>  first registered handler.  When it's without SA_INTERRUPT, always
>  local_irq_enable() is called even if the second or later handler has
>  SA_INTERRUPT.

That's because SA_INTERRUPT interrupts shouldn't be shared.  The grey cell
which remembered why this is so seems to have died, but I've put the email
thread here: http://www.zip.com.au/~akpm/linux/patches/stuff/x.txt

  parent reply	other threads:[~2004-08-25  3:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-23 17:10 Takashi Iwai
2004-08-23 17:29 ` Takashi Iwai
2004-08-23 18:09   ` Zwane Mwaikambo
2004-08-25  3:45 ` Andrew Morton [this message]
2004-08-25 11:17   ` Takashi Iwai
2004-08-25 20:41     ` Andrew Morton
2004-08-26 12:50       ` Takashi Iwai
2004-08-26 14:04         ` Russell King
2004-08-26 14:10           ` Takashi Iwai
2004-08-26 14:18             ` Russell King
2004-08-26 14:27               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040824204508.3b31449f.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas@undata.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome