From: Andrew Morton <akpm@osdl.org>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [4/5] eliminate bh waitqueue hashtable
Date: Sat, 28 Aug 2004 15:37:28 -0700 [thread overview]
Message-ID: <20040828153728.38e7f85a.akpm@osdl.org> (raw)
In-Reply-To: <20040828201107.GV5492@holomorphy.com>
William Lee Irwin III <wli@holomorphy.com> wrote:
>
> +static inline int wait_on_bit(void *word, int bit,
> + int (*action)(void *), unsigned mode)
> +{
> + DEFINE_WAIT_BIT(q, word, bit);
> + wait_queue_head_t *wqh;
> +
> + if (!test_bit(bit, word))
> + return 0;
> +
> + wqh = bit_waitqueue(word, bit);
> + return __wait_on_bit(wqh, &q, word, bit, action, mode);
> +}
This is still all inlined. Given that we're going to schedule away,
don't you think we should out-of-line the slowpath? As I said yesterday:
static inline int wait_on_bit(...)
{
if (test_bit(...))
return out_of_line_wait_on_bit(...);
return 0;
}
I merged this latest batch into -mm.
next prev parent reply other threads:[~2004-08-28 22:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-28 20:05 [0/5] standardized waitqueue hashing William Lee Irwin III
2004-08-28 20:06 ` [1/5] move waitqueue functions to kernel/wait.c William Lee Irwin III
2004-08-28 20:08 ` [2/5] consolidate bit waiting code patterns William Lee Irwin III
2004-08-28 20:09 ` [3/5] " William Lee Irwin III
2004-08-28 20:11 ` [4/5] eliminate bh waitqueue hashtable William Lee Irwin III
2004-08-28 20:12 ` [5/5] eliminate inode " William Lee Irwin III
2004-08-28 22:37 ` Andrew Morton [this message]
2004-08-28 23:09 ` [4/5] eliminate bh " William Lee Irwin III
2004-08-28 20:21 ` [2/5] consolidate bit waiting code patterns William Lee Irwin III
2004-08-28 22:29 ` Andrew Morton
2004-08-28 22:33 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040828153728.38e7f85a.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome